Bug 116796 – emerge -pv doesn't show the correct download size if partial download exists

• Product: Portage Development
• Status: RESOLVED FIXED

[Description Yuval Yaari (RETIRED) 2005-12-26 11:22:50 UTC]

When downloading a partial file, emerge -pv would assume the file was downloaded in its entirety.

danzig ~ # emerge -pv sourcenav

These are the packages that I would merge, in order:

Calculating dependencies ...done!
[ebuild  N    ] dev-util/sourcenav-5.1.4  10,846 kB

Total size of downloads: 10,846 kB
danzig ~ # touch /usr/portage/distfiles/sourcenav-5.1.4.tar.gz
danzig ~ # emerge -pv sourcenav

These are the packages that I would merge, in order:

Calculating dependencies ...done!
[ebuild  N    ] dev-util/sourcenav-5.1.4  4 kB

Total size of downloads: 4 kB
danzig ~ # emerge info
Portage 2.0.53 (default-linux/x86/2005.1, gcc-3.4.4, glibc-2.3.5-r2, 2.6.14-gentoo-r2 i686)
=================================================================
System uname: 2.6.14-gentoo-r2 i686 Intel(R) Pentium(R) 4 CPU 2.80GHz
Gentoo Base System version 1.6.13
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.3 [enabled]
dev-lang/python:     2.3.5-r2, 2.4.2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1
sys-devel/libtool:   1.5.20
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium4 -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/splash /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=pentium4 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://mirror.hamakor.org.il/pub/mirrors/gentoo/ http://213.186.33.38/gentoo-distfiles/ ftp://ftp.snt.utwente.nl/pub/os/linux/gentoo ftp://213.186.33.37/gentoo-distfiles/ http://213.186.33.37/gentoo-distfiles/ ftp://ftp.nyx.hu/gentoo http://ftp.heanet.ie/pub/gentoo/ ftp://ftp.heanet.ie/pub/gentoo/ ftp://213.186.33.38/gentoo-distfiles/ ftp://ftp.linux.ee/pub/gentoo/distfiles/ http://ftp.linux.ee/pub/gentoo/distfiles/ http://gentoo.seren.com/gentoo http://213.186.33.38/gentoo-distfiles/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="x86 X alsa apm arts audiofile avi bash-completion berkdb bitmap-fonts bzip2 crypt cups curl eds emacs emboss encode ethereal expat fam flac foomaticdb fortran gd gdbm gif gpm gstreamer gtk2 i8x0 idn imagemagick imlib ipv6 java jpeg kde lcms ldap libg++ libwww mad mhash mikmod mng motif mp3 mpeg ncurses nls ogg oggvorbis opengl oss pam pcre pdflib perl pic png python qt quicktime readline samba sdl spell ssl tcpd tiff truetype truetype-fonts type1-fonts udev vorbis xml2 xmms xv xvid zlib video_cards_i810 video_cards_i830 userland_GNU kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTDIR_OVERLAY

[Comment 1 Yuval Yaari (RETIRED) 2005-12-26 11:39:20 UTC]

Created attachment 75561 [details, diff]
Patch to portage.py to ignore the partial download, and completely ignore the partial size

[Comment 2 Yuval Yaari (RETIRED) 2005-12-26 11:42:10 UTC]

Created attachment 75562 [details, diff]
Patch to portage.py to concider the partial download's size

[Comment 3 Jan Kundrát (RETIRED) 2006-01-03 01:58:44 UTC]

You don't have to check hashes of downloaded files, IMHO, as it is not strictly required for viewing pretended installs. Size checking is enough.

[Comment 4 Zac Medico 2006-04-21 15:38:06 UTC]

This is fixed in svn r3185.  Partial downloads are now considered by checking the file size only (no checksum is performed, in order to avoid excessive IO overhead).

[Comment 5 Zac Medico 2006-04-23 01:35:26 UTC]

Released in 2.1_pre9-r4.

[Comment 6 Zac Medico 2007-01-18 20:59:42 UTC]

*** Bug 65575 has been marked as a duplicate of this bug. ***