| Summary: | invalid use of wget in src_unpack for hddtemp-0.3_beta1* ebuilds | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Alec Warner (RETIRED) <antarus> |
| Component: | Current packages | Assignee: | Daniel Ahlberg (RETIRED) <aliz> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | qa, spock |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
i dont really think this is an issue ... the .db file is constantly updated upstream, the wget has a small timeout, and if it fails, there is a local (old) cache to fall back on As Zac suggested on IRC, put the fetching in pkg_config and inform the user that they have to run it after installation to fetch the newer db. The pkg_config idea sounds best to me if this is a moving target. Spock, any reason not to change it? The only reason for not changing it earlier was that I've forgotten about this bug (since it wasn't assinged to me) :) A fixed ebuild is now in CVS. I didn't want to make any changes in the old ebuilds, so we'll have to wait for the new one to be marked stable so that -beta13 can be removed from the tree. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=596aef4ad0d83ab31cdafb083f0cc26a892abd11 commit 596aef4ad0d83ab31cdafb083f0cc26a892abd11 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2019-07-19 16:27:44 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2019-07-19 16:34:13 +0000 app-admin/hddtemp: [QA] Remove pkg_config(). This tried to download the latest version of hddtemp.db, which should be done in a live ebuild instead. Besides, there appears to be no upstream activity, and (as of today) the "latest" version is from 2007. No revbump, because installed files don't change. Bug: https://bugs.gentoo.org/116348 Package-Manager: Portage-2.3.69, Repoman-2.3.16 Signed-off-by: Ulrich Müller <ulm@gentoo.org> app-admin/hddtemp/hddtemp-0.3_beta15-r27.ebuild | 10 ---------- 1 file changed, 10 deletions(-) |
src_unpack() { unpack ${A} ; cd ${S} epatch ${FILESDIR}/${P}-setsid.patch ebegin "Trying to download the latest hddtemp.db file" wget -q --timeout=10 http://www.guzu.net/linux/hddtemp.db eend $? } wget should not be used in src_unpack. That db file should be in SRC_URI instead of in src_unpack, so that portage can fetch and digest it properly. This also defeats people who use emerge -f to fetch all important files, only to fail here with no internet connection.