| Summary: | jrisk in-game help browser is hard-coded to firefox | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Denilson Sá Maia <denilsonsa> |
| Component: | [OLD] Games | Assignee: | Gentoo Games <games> |
| Status: | RESOLVED UPSTREAM | ||
| Severity: | minor | CC: | phajdan.jr, vcover |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | jRisk-firefox.patch | ||
|
Description
Denilson Sá Maia
2005-12-18 17:42:17 UTC
All 3 buttons work for me on games-board/jrisk-1.0.8.5 on amd64 I browsed through the jRisk code and found mozilla being the default (hardcoded) "help viewer". A more sane choice would be firefox IMO, the following patch just switches mozilla to firefox in risk/Risk.java. If requested by the developers I'll make an IUSE="doc"-type ebuild which would then require firefox as a dep. Created attachment 91707 [details, diff]
jRisk-firefox.patch
I would prefer to use "links -g" as my help viewer. Is there any way to not hardcode that setting? Well, even if it will be kept hardcoded, please add some einfo/ewarn at ebuild, explaining it. Not hardcoding a single browser would go way beyond the scope of a patch, that would be the job of the actual game developer. The best we can do is to make it work for as many people as possible, that's why I suggested using firefox. (In reply to comment #5) > The best we can do is to make it work for as many people as possible, > that's why I suggested using firefox. I understand. I have another suggestion, but I'm not sure if it is feasible. The ebuild could detect which browser is currently installed (among a list of available browsers: links, dillo, mozilla-firefox{,-bin}, mozilla, seamonkey, opera, ...) and then apply the patch according to which is installed. Of course, this has a problem: if the user uninstall any of the browsers, the package would be broken and would need to be re-emerged. But, anyway, without any patch it is already broken... This really needs to be addressed upstream. Any general solution should be directed that way. I wrote a mail to the developer, we'll see if he's willing to provide a solution. Seems to be fixed as of games-board/jrisk-1.0.8.7. Really? It works for you even though you don't have firefox installed? (In reply to comment #10) > Really? It works for you even though you don't have firefox installed? Sorry, no. I saw a BrowserLauncher class and thought it really detects browser, but on linux firefox is hardcoded. By the way: Suggestion #1: change bug summary to something like "browser path hardcoded in games-board/jrisk" Suggestion #2: make jRisk-firefox.patch obsolete (in 1.0.8.7 there is firefox instead of mozilla, so this patch is not needed IMO) Comment on attachment 91707 [details, diff]
jRisk-firefox.patch
As mentioned in previous comments, simply changing the hard-coding isn't enough. The code should figure out the right browser to use.
Needs to be fixed by upstream. |
