Bug 115938

Summary:	x11-misc/xfishtank-2.1: replace -g in Makefile with CFLAGS
Product:	Gentoo Linux	Reporter:	Toralf Förster <toralf>
Component:	Current packages	Assignee:	Desktop Misc. Team <desktop-misc>
Status:	RESOLVED FIXED
Severity:	enhancement
Priority:	High
Version:	2005.1
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Toralf Förster gentoo-dev

2005-12-18 07:10:14 UTC

Actually the executable is compiled using debug information.
What about to replace the string "-g" in the Makefile" with the CFLAGS defined in /etc/make.conf ?
BTW I tried to generate the Makefile from the given Imakefile using "xmkmf -a" but that failed for the xfishtank.man target :-(

Comment 1 Krzysztof Pawlik (RETIRED) gentoo-dev

2005-12-18 07:30:27 UTC

Fixed in CVS in 2.1.

Comment 2 Toralf Förster gentoo-dev

2005-12-19 12:43:29 UTC

Great :-)

Adding this patch would also remove the debug information from the executable itself (didn't found a quick solution to add the CFLAGS from make.conf here, too) :

n22 /var/tmp/portage/xfishtank-2.1/work/xfishtank-2.1tp # diff -u Makefile.orig Makefile
--- Makefile.orig       2005-12-19 21:35:23.000000000 +0100
+++ Makefile    2005-12-19 21:40:16.000000000 +0100
@@ -216,7 +216,7 @@
         LINTFLAGS = $(LINTOPTS) -DLINT $(ALLDEFINES) $(DEPEND_DEFINES)
          LDPRELIB = -L$(USRLIBDIR)
         LDPOSTLIB =
-        LDOPTIONS = $(CDEBUGFLAGS) $(CCOPTIONS)  $(EXTRA_LDOPTIONS) $(THREADS_LDFLAGS) $(LOCAL_LDFLAGS) $(LDPRELIB)
+        LDOPTIONS = $(CCOPTIONS)  $(EXTRA_LDOPTIONS) $(THREADS_LDFLAGS) $(LOCAL_LDFLAGS) $(LDPRELIB)
      CXXLDOPTIONS = $(CXXDEBUGFLAGS) $(CXXOPTIONS) $(EXTRA_LDOPTIONS) $(THREADS_CXXLDFLAGS) $(LOCAL_LDFLAGS) $(LDPRELIB)

            LDLIBS = $(LDPOSTLIB) $(THREADS_LIBS) $(SYS_LIBRARIES) $(EXTRA_LIBRARIES)

Comment 3 Krzysztof Pawlik (RETIRED) gentoo-dev

2005-12-19 12:49:50 UTC

portage performs stripping of binaries, so the debug symbols are removed.