Bug 115299 – sdl-sound should have optional smpeg support

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Chris Gianelloni (RETIRED) 2005-12-12 05:57:24 UTC]

According to bug #100965, sdl-sound needs optional smpeg support for alephone to
work properly with the original Marathon data files from Bungie.

Here's a simple ebuild patch.  Since I am unfamiliar with why smpeg support was
explicitly disabled, I'm filing this as a bug.

Index: sdl-sound-1.0.1-r2.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/media-libs/sdl-sound/sdl-sound-1.0.1-r2.ebuild,v
retrieving revision 1.2
diff -u -b -B -r1.2 sdl-sound-1.0.1-r2.ebuild
--- sdl-sound-1.0.1-r2.ebuild   30 Sep 2005 18:48:46 -0000      1.2
+++ sdl-sound-1.0.1-r2.ebuild   12 Dec 2005 13:55:36 -0000
@@ -12,7 +12,7 @@
 LICENSE="LGPL-2.1"
 SLOT="0"
 KEYWORDS="~amd64 ~ppc ~x86"
-IUSE="flac mikmod vorbis speex physfs mp3"
+IUSE="flac mikmod vorbis speex physfs mp3 mpeg"

 RDEPEND=">=media-libs/libsdl-1.2
        flac? ( media-libs/flac )
@@ -20,7 +20,8 @@
        vorbis? ( >=media-libs/libvorbis-1.0_beta4 )
        speex? ( media-libs/speex
                media-libs/libogg )
-       physfs? ( dev-games/physfs )"
+       physfs? ( dev-games/physfs )
+       mpeg? ( media-libs/smpeg )"
 DEPEND="${RDEPEND}
        dev-util/pkgconfig"

@@ -33,7 +34,7 @@
        econf \
                --disable-dependency-tracking \
                --enable-midi \
-               --disable-smpeg \
+               $(use_enable mpeg smpeg) \
                $(use_enable mp3 mpglib) \
                $(use_enable flac) \
                $(use_enable speex) \

[Comment 1 Chris Gianelloni (RETIRED) 2006-01-11 12:07:41 UTC]

I've added this to CVS... let's hope it doesn't kill anything...

[Comment 2 Gregory Smith 2006-02-11 06:10:54 UTC]

you need to re-add the gcc331.patch or it won't build in SMPEG
(using amd64 and gcc 3.4.4-r1 here)

[Comment 3 Chris Gianelloni (RETIRED) 2006-02-11 08:29:38 UTC]

Strange, I tested it on amd64.  What error are you getting exactly?

[Comment 4 Gregory Smith 2006-02-11 08:59:36 UTC]

...
checking for smpeg-config... /usr/bin/smpeg-config
checking for SMPEG - version >= 0.4.3... no
*** Could not run SMPEG test program, checking why...
*** The test program compiled, but did not run. This
usually means
*** that the run-time linker is not finding SMPEG or
finding the wrong
*** version of SMPEG. If it is not finding SMPEG, you'll
need to set your
*** LD_LIBRARY_PATH environment variable, or edit
/etc/ld.so.conf to point
*** to the installed location  Also, make sure you have run
ldconfig if that
*** is required on your system
***
*** If you have an old version installed, it is best to
remove it, although
*** you may also be able to get things to work by modifying
LD_LIBRARY_PATH
...


running smpeg-config --version gives me 0.4.4

the problem is the acinclude.m4 that comes with SDL_Sound has string literals with literal newlines in them, which gcc apparently can't parse any more

adding gcc331.patch and the corresponding aclocal hacks from sdl-sound-1.0.1.ebuild into my overlay makes it compile in SMPEG