Bug 114694

Summary:	netkit-rwho- 0.17-r1: rwhod does not work on amd4, does not expire old rwhod entries and does not allow overriding startup flags with /etc/conf.d
Product:	Gentoo Linux	Reporter:	Philippe Troin <phil>
Component:	[OLD] Server	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	VERIFIED FIXED
Severity:	normal	CC:	netmon
Priority:	High
Version:	unspecified
Hardware:	AMD64
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	68840
Attachments:	Rwhod debian patch. /etc/conf.d/rwhod Updated /etc/init.d/rwhod file to pass arguments to rwhod as defined in /etc/conf.d/rwhod Suggested /etc/cron.monthly/rwhod script. Updated ebuild.

Description Philippe Troin 2005-12-06 21:33:14 UTC

That's a long summary.
My gripes are:

 #1. rwhod does not work on amd64: it complains in the syslog: ioctl (get
interface flags).

 #2. old entries in /var/spool/rwho are never removed

 #3. /etc/init.d/rwhod does not allow overriding flags passed to rwhod via
/etc/conf.d

Plus, 

  #4. the Debian version of rwhod has many more flags (-f and -i) to allow more
fine-grained selection of active interfaces.

Comment 1 Philippe Troin 2005-12-06 21:36:43 UTC

Created attachment 74205 [details, diff]
Rwhod debian patch.

This patch synchronizes gentoo's netkit-rwho with the Debian version.
This takes care of problems #1 and #4.
Please note that this patch:

 - fixes the memory corruption on AMD64,

 - adds the new -u <user> flag to run rwho without privileges,

 - add the new -f flag to forward rwho packets in between active interfaces

 - add the new -i <if> flag to select which interfaces rwho is going to send
packets on

This patch has been used on Debian systems for at least over one year, without
complaints.

Comment 2 Philippe Troin 2005-12-06 21:37:41 UTC

Created attachment 74206 [details]
/etc/conf.d/rwhod

Suggested rwod configuration defaults.

Comment 3 Philippe Troin 2005-12-06 21:39:23 UTC

Created attachment 74207 [details]
Updated /etc/init.d/rwhod file to pass arguments to rwhod as defined in /etc/conf.d/rwhod

The patches /etc/conf.d/rwhod and this one (/etc/init.d/rwhod) take care of
problem #3.

Comment 4 Philippe Troin 2005-12-06 21:39:55 UTC

Created attachment 74208 [details]
Suggested /etc/cron.monthly/rwhod script.

This takes care of problem #2.

Comment 5 Philippe Troin 2005-12-06 21:40:49 UTC

Created attachment 74209 [details]
Updated ebuild.

This updated ebuild integrates all the changes (#1-#4).

Comment 6 Benjamin Smee (strerror) (RETIRED) gentoo-dev

2005-12-07 12:47:40 UTC

Thanks for the contribution, this solves a couple of rwho issues. In cvs.

Comment 7 Philippe Troin 2005-12-07 14:20:44 UTC

Verfied that the new ebuild works on amd64.