Bug 114558

Summary:	glide-v3-3.10-r4 fails to compile with gcc-3.4.4
Product:	Gentoo Linux	Reporter:	Christopher Head <bugs>
Component:	[OLD] Library	Assignee:	X11 External Driver Maintainers <x11-drivers>
Status:	VERIFIED FIXED
Severity:	blocker	CC:	alba74
Priority:	High
Version:	2005.1
Hardware:	x86
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	This is my proposed patch

Description Christopher Head 2005-12-05 12:37:04 UTC

Summary says it all. There's an error in glide3x/h3/minihwc/linhwc.c about
hwcBufferLfbAddr being redefined on line 611, original definition line 356. This
is because the function is declared implicitly by usage on line 356, where there
is no prototype in scope. The problem is fixed by placing a prototype for
hwcBufferLfbAddr() before the beginning of the function which contains line 356.

There is also an error in glide3x/h3/glide3/src/xdraw2.inc.S regarding the
GR_FIFO_WRITE macro being defined multiple times on line 815 because the file
appears to be included multiple times. This is eliminated by placing a guard
block around the macro definition.

I will attach a patch file which, when applied after the "-fixes" and
"-2.6-headers-fix" patches, fixes these problems and allows compilation to finish.

Comment 1 Christopher Head 2005-12-05 12:38:43 UTC

Created attachment 74110 [details, diff]
This is my proposed patch

Comment 2 Tuomas Suutari 2005-12-15 15:29:11 UTC

I confirm that the patch works.

Comment 3 Donnie Berkholz (RETIRED) gentoo-dev

2006-01-28 02:10:18 UTC

Fixed, thanks! Could you please submit this upstream if it isn't already? glide.sf.net is the place. It sounds like they'll be doing a new release pretty soon -- hopefully the build process isn't impossible as the last one was.

Comment 4 Donnie Berkholz (RETIRED) gentoo-dev

2006-01-28 02:13:04 UTC

*** Bug 118628 has been marked as a duplicate of this bug. ***

Comment 5 Christopher Head 2006-01-28 18:59:11 UTC

Submitted upstream as requested.