Bug 114501

Summary:	emacs-cvs ebuild applies patches in src_compile
Product:	Gentoo Linux	Reporter:	Colin Macdonald <cbm>
Component:	New packages	Assignee:	Matthew Kennedy (RETIRED) <mkennedy>
Status:	RESOLVED FIXED
Severity:	normal	CC:	emacs
Priority:	High
Version:	2005.1
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Colin Macdonald 2005-12-04 22:48:15 UTC

emacs-cvs ebuild applies patches in src_compile instead of in src_unpack.  This
means that if one uses the ebuild command (as opposed to emerge), there can be
problems where the code is patched twice.

I think the problem could be reproduced like this:
ebuild emacs-cvs-xx.xx.ebuild unpack
ebuild emacs-cvs-xx.xx.ebuild compile  (and then ctrl-c part way through the
compile)
ebuild emacs-cvs-xx.xx.ebuild compile  (will fail because the patches have
already been applied)

The ebuilds should have a src_pack() which calls cvs_src_pack() (from
cvs.eclass) and then uses epatch.  I tried to do but was unsuccessful---I don't
know enough about eclasses.

Comment 1 Colin Macdonald 2006-02-09 10:55:13 UTC

Fixed in emacs-cvs-22.0.50-r1 (currently masked).