| Summary: | Bump sys-fs/fuse to 2.4.2, please | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Radek Podgorny <radek> |
| Component: | New packages | Assignee: | Stefan Schweizer (RETIRED) <genstef> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | pete4abw |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
fuse-2.4.1.patch
fuse-2.4.2.patch |
||
|
Description
Radek Podgorny
2005-11-27 14:30:09 UTC
This is already fixed in 2.4.1-r1 (Bug 112902) You may wish to include this patch which fixes a bad memory leak then. And 2.4.2
IS a new release not included in 2.4.1-r1.
From fuse-devel newsgroup by author, Miklos Szeredi
Index: lib/fuse.c
===================================================================
RCS file: /cvsroot/fuse/fuse/lib/fuse.c,v
retrieving revision 1.148
diff -u -r1.148 fuse.c
--- lib/fuse.c 28 Nov 2005 16:02:27 -0000 1.148
+++ lib/fuse.c 2 Dec 2005 11:00:31 -0000
@@ -1742,6 +1742,7 @@
void fuse_process_cmd(struct fuse *f, struct fuse_cmd *cmd)
{
fuse_session_process(f->se, cmd->buf, cmd->buflen, cmd->ch);
+ free_cmd(cmd);
}
int fuse_exited(struct fuse *f)
@@ -1779,6 +1780,8 @@
int res = fuse_chan_receive(ch, cmd->buf, bufsize);
if (res <= 0) {
free_cmd(cmd);
+ if (res == -1)
+ fuse_exit(f);
return NULL;
}
cmd->buflen = res;
This is a bad one. Line #s against 2.4.1 are very different though. See functions:
void fuse_process_cmd (diff begins at line 1656)
struct fuse_cmd *fuse_read_cmd (diff begins at line 1693)
I strongly recommend upgrading to 2.4.2 and modifying the above patch to repair
the leak.
Created attachment 74016 [details, diff]
fuse-2.4.1.patch
fix memory leak
Created attachment 74017 [details, diff]
fuse-2.4.2.patch
fix memory leak. I strongly recommend implementing 2.4.2. Lots of changes. In
addition, I also suggest having a cvs version as is done with enlightenment.
Have a version 2.4.9999 which will pull in cvs for this series on demand by
user.
Thanks, fixed |
