Summary: | nethack-3.4.3-r2.ebuild + patch | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Kiyoshi Aman <kiyoshi.aman> |
Component: | [OLD] Games | Assignee: | Mira Ressel <aranea> |
Status: | RESOLVED WONTFIX | ||
Severity: | enhancement | CC: | james, jer |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 104707, 109013, 109191 | ||
Attachments: |
nethack-3.4.3-r2.ebuild
3.4.3-gentoo.patch nethack-3.4.3-r2.ebuild try 2 nethack-3.4.3-r2.ebuild yet another ebuild updated .nethackrc Because Nethack checks HACKDIR for tiles Updated patch; fixes savepath issue once and for all, hopefully. ebuild with Russian translation patch for russian translation english/russian ebuild with unicode use |
Description
Kiyoshi Aman
2005-11-21 19:47:51 UTC
Blocking appropriate bugs. Created attachment 73344 [details]
nethack-3.4.3-r2.ebuild
Created attachment 73345 [details, diff]
3.4.3-gentoo.patch
Created attachment 73398 [details]
nethack-3.4.3-r2.ebuild try 2
Oops, missed some gnomes in the move to USE="gtk" respect.
Created attachment 73441 [details]
nethack-3.4.3-r2.ebuild
Tiles don't go in /usr/share/pixmaps
This also fixes the issue where tiles got put in / because PIXMAPDIR isn't set.
Oops.
Created attachment 73443 [details]
yet another ebuild
This one puts tiles in ${GAMES_DATADIR}/${PN}, unlike the old one.
Created attachment 73444 [details]
updated .nethackrc
This will set some sensible defaults in Nethack, some of which use the new
features.
Created attachment 73451 [details]
Because Nethack checks HACKDIR for tiles
Intermediate ebuild until I write a patch to apply for gtk so it can find the
tiles properly.
what about changing the right ressources in /etc/X11/app-defaults/NetHack? IIRC there is one for the tile file location. There's one to tell Nethack what the filename is, but I don't know if it will honour an absolute path. With the latest version of the ebuild: i686-pc-linux-gnu-gcc -O3 -march=c3-2 -I../include -c -o files.o files.c files.c: In function `get_saved_games': files.c:1002: error: `SAVE_PREFIX' undeclared (first use in this function) files.c:1002: error: (Each undeclared identifier is reported only once files.c:1002: error: for each function it appears in.) i686-pc-linux-gnu-gcc -O3 -march=c3-2 -I../include -c -o fountain.o fountain.c make: *** [files.o] Error 1 make: *** Waiting for unfinished jobs.... !!! ERROR: games-roguelike/nethack-3.4.3-r2 failed. This should fix it... --- files/3.4.3-gentoo.patch-old 2005-11-22 06:28:53.000000000 +0100 +++ files/3.4.3-gentoo.patch 2005-11-30 04:12:43.000000000 +0100 @@ -2784,7 +2784,7 @@ int myuid=getuid(); struct dirent **namelist; - int n = scandir("save", &namelist, 0, alphasort);; -+ int n = scandir(fqname("save",SAVE_PREFIX,0), &namelist, 0, alphasort);; ++ int n = scandir(fqname("save",SAVEPREFIX,0), &namelist, 0, alphasort);; if ( n > 0 ) { int i,j=0; char** result = (char**)alloc((n+1)*sizeof(char*)); /* at most */ It works with all use flags but OPTIONS=windowtype:gnome does not work properly yet. I get this error (after nethack has crashed and dissappeared from the screen: jeroen@epia ~ $ nethack Gdk-ERROR **: BadMatch (invalid parameter attributes) serial 28085 error_code 8 request_code 62 minor_code 0 Gdk-ERROR **: BadMatch (invalid parameter attributes) serial 28089 error_code 8 request_code 62 minor_code 0 jeroen@epia ~ $ The other modes (tty, qt, x11) work fine. Created attachment 73835 [details, diff]
Updated patch; fixes savepath issue once and for all, hopefully.
Updated ebuild to address the gnome -> gtk breakage up shortly.
Argh. I just checked the ebuild, and it doesn't seem to have an issue. Additionally, it works for me; I don't know why windowtype:gnome isn't working for you. Ack, forgot this doesn't have an edit button... I only tried it without specifying windowtype:gnome specifically, and it *seems* to work just fine in that instance. [I have -qt in my use flags, so I don't know if Qt is interfering in some way.] Hello all, doing some bug triage through our old bugs and noticed this one. The situation is this: we have version 3.4.3-r1 in portage already, currently hardmasked due to security issues. This bug here is a proposed ebuild for 3.4.3. I would close it if not for the proposed patches which I cannot evaluate are needed in the portage version. Advice on what needs doing is appreciated as conversation on this one and dependencies died out a long time ago. The patches applied herein are enhancements above and beyond those present in the Debian packages. It's been years, however, and I am no longer interested in working with Nethack in Gentoo; Sporkhack has since arisen, and needs packaging. Created attachment 202284 [details] ebuild with Russian translation please, integrate into it gtk this is actual gtk2 interface: http://gtk2hack.sourceforge.net Created attachment 202285 [details, diff]
patch for russian translation
Created attachment 202312 [details]
english/russian ebuild with unicode use
The GTK port seems to be abandoned, so I won't include it in our ebuild. I'm thinking about adding in a few common patches, but as the choice of nethack patches is highly subjective and many patches are incompatible with each other, I won't rush this. I've added an epatch_user call to the ebuild, though, so you can just drop your patches in /etc/portage/patches. |