Bug 113214 – sys-kernel/openvz-sources-022.045: typo in hugetlbpage.c

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Christian Zoffoli (RETIRED) 2005-11-21 17:08:52 UTC]

There's a typo in hugetlbpage.c --> compilation stop if hugetlb is enables

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Actual Results:  
  CC      arch/i386/mm/ioremap.o
  CC      arch/i386/mm/extable.o
  CC      arch/i386/mm/pageattr.o
  CC      arch/i386/mm/hugetlbpage.o
arch/i386/mm/hugetlbpage.c: In function `copy_hugetlb_page_range':
arch/i386/mm/hugetlbpage.c:89: error: `mm' undeclared (first use in this function)
arch/i386/mm/hugetlbpage.c:89: error: (Each undeclared identifier is reported
only once
arch/i386/mm/hugetlbpage.c:89: error: for each function it appears in.)
arch/i386/mm/hugetlbpage.c: In function `unmap_hugepage_range':
arch/i386/mm/hugetlbpage.c:226: error: `PAGE_SIFT' undeclared (first use in this
function)
make[1]: *** [arch/i386/mm/hugetlbpage.o] Error 1
make: *** [arch/i386/mm] Error 2



omega linux # emerge info
Portage 2.0.51.22-r3 (default-linux/x86/2005.1, gcc-3.3.6, glibc-2.3.5-r2,
2.6.12-gentoo-r9 i686)
=================================================================
System uname: 2.6.12-gentoo-r9 i686 Intel(R) Xeon(TM) CPU 2.80GHz
Gentoo Base System version 1.6.13
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.3 [enabled]
dev-lang/python:     2.3.5, 2.4.2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.15.92.0.2-r10
sys-devel/libtool:   1.5.20
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium4 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config
/usr/share/config /var/bind /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=pentium4 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig buildpkg ccache distlocks sandbox sfperms strict"
GENTOO_MIRRORS=" ftp://pandemonium.tiscali.de/pub/gentoo/
http://pandemonium.tiscali.de/pub/gentoo/ http://mir.zyrianes.net/gentoo/"
LINGUAS="it"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="x86 apache2 apm avi berkdb bitmap-fonts bzip2 crypt cups curl eds emboss
encode expat foomaticdb fortran gdbm gif gpm gstreamer gtk2 imlib jpeg ldap
libg++ libwww mad mailwrapper mhash mikmod motif mp3 mpeg mysql ncurses nls nptl
nptlonly ogg oggvorbis opengl oss pam pcre pdflib perl png postgres python
quicktime readline sdl spell ssl tcpd truetype truetype-fonts type1-fonts udev
vhosts vorbis xml2 xmms xv zlib linguas_it userland_GNU kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS

[Comment 1 Christian Zoffoli (RETIRED) 2005-11-21 17:10:02 UTC]

Created attachment 73337 [details, diff]
typo fix

[Comment 2 Kir Kolyshkin 2005-11-22 03:26:10 UTC]

Created attachment 73364 [details, diff]
fixes both typos

[Comment 3 Kir Kolyshkin 2005-11-22 23:04:51 UTC]

My patch fixes both compilation issues with hugetlbpage. 

Still, it is not recommended to have CONFIG_HUGETLFBS=y on an OpenVZ kernels. As
a developer puts in, "with CONFIG_HUGETLBFS, memory accounting will be
unpredictable anyway".

[Comment 4 Christian Heim (RETIRED) 2005-11-25 06:36:58 UTC]

just commited a version bump, fixing this issue. Thanks a lot!