Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 110470

Summary: Get "aotuv" USE flag working in latest libvorbis.
Product: Gentoo Linux Reporter: Charlton Harrison <charlton>
Component: New packagesAssignee: Gentoo Sound Team <sound>
Status: RESOLVED DUPLICATE    
Severity: major CC: dv5a, gentoo
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Charlton Harrison 2005-10-25 13:47:49 UTC
With the USE flag "aotuv",  libvorbis 1.0.1 compiled with the aotuv-b3 patch.
Now there's aotuv-b4 out, with a known merge for libvorbis 1.1.1.  However,
currently libvorbis builds without this patch even with the aotuv flag set.

Also, there is no way to gather information at runtime (from version information
from oggenc or otherwise) that libvorbis has or has not been patched.  It would
be very appropriate to have instead of this:

# oggenc --version
OggEnc v1.0.1 (libvorbis 1.0.1)

This:

# oggenc --version
OggEnc v1.1.1 (libvorbis 1.1.1 with aoTuV-beta4 patch)

Otherwise there's no way for system users to know what they're encoding with!


Reproducible: Always
Steps to Reproduce:
1.set aotuv USE flag in make.conf
2.emerge libvorbis-1.1.1
3.

Actual Results:  
libvorbis-1.1.1 compiled without the aotuv patch

Expected Results:  
libvorbis-1.1.1 should compile WITH the aotuv patch (provided the aotuv USE flag
is set),  AND it needs to indicate that it is patched inside the libvorbis
runtime version indicator.
Comment 1 trefoil 2006-01-06 09:34:24 UTC
This isn't strictly a bug, as libvorbis-1.1.1 doesn't have an aotuv use flag. But I strongly second this as an RFE. Currently aotuv b4.51 offers significant, ABX-able improvements over the earlier version which was merged with mainline.

Charlton: although it's less convenient than what you proposed, you can run ogginfo on an encoded file to figure out what encoder was used. See this page for tons of info:
http://www.hydrogenaudio.org/forums/index.php?showtopic=15049

I'll try to work on a revised ebuild.
Comment 2 Henrique Dante de Almeida 2006-02-10 15:21:10 UTC
(In reply to comment #1)
> This isn't strictly a bug, as libvorbis-1.1.1 doesn't have an aotuv use flag.
> But I strongly second this as an RFE. Currently aotuv b4.51 offers significant,
> ABX-able improvements over the earlier version which was merged with mainline.
> 
> Charlton: although it's less convenient than what you proposed, you can run
> ogginfo on an encoded file to figure out what encoder was used. See this page
> for tons of info:
> http://www.hydrogenaudio.org/forums/index.php?showtopic=15049
> 
> I'll try to work on a revised ebuild.
> 


 Hi,

 I'd like to propose another thing, that IMHO would be the Good Thing to do. libvorbis should be split into libvorbis-xiph and libvorbis-aotuv. Let the user choose between the reference library and the enthusiasts-recommended one. Even the version numbering is different. I don't know how to exactly solve dependencies, but you could try to use a libvorbis virtual package, with mutually exclusive USE flags 'vorbis-aotuv', 'vorbis-xiph' (maybe SLOTs ?).
Comment 3 Saurabh Singhvi 2007-01-18 19:48:54 UTC
with libvorbis 1.1.2, the problem still doesn't seem to have been solved. 
someone kindly rectify this :)
Comment 4 trefoil 2007-01-18 23:23:00 UTC
Ehm, works fine for me. How do you think it's not working?
Comment 5 Alexis Ballier gentoo-dev 2007-02-24 18:16:05 UTC
We'll handle that in that bug, I think it would be better to go with separating libvorbis into two separate packages and introduce virtual/libvorbis

*** This bug has been marked as a duplicate of bug 157549 ***