Summary: | Additional symbol visibility fixes for gcc 4. | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Simon Strandman <simon.strandman> |
Component: | [OLD] GCC Porting | Assignee: | Gentoo Toolchain Maintainers <toolchain> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | 4.0.2-r3 | ||
Package list: | Runtime testing required: | --- |
Description
Simon Strandman
2005-10-17 14:22:14 UTC
Apparently the patch for 20297 doesn't completely solve the problem. Firefox still fails to build on amd64. Check my comment in that bug for more info. Ignore the patch for #20297, it doesn't work. Once the patches are accepted upstream, I'll add them. Last time I took some of these visibility fixes, they introduced ICEs, so I'd rather avoid that just to fix -fvisibility. This patch is already accepted upstream for 4.1 and it's included in the 3.4 patchset (23_all_gcc34-visibility4.patch). Here is the commit: Subject: Bug 19664 CVSROOT: /cvs/gcc Module name: gcc Changes by: hjl@gcc.gnu.org 2005-05-17 21:47:13 Modified files: gcc/cp : ChangeLog decl2.c Log message: 2005-05-17 H.J. Lu <hongjiu.lu@intel.com> PR C++/19664 * decl2.c (determine_visibility): Don't set visibility to hidden if it has been set explicitly by user. Patches: http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4745&r2=1.4746 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/decl2.c.diff?cvsroot=gcc&r1=1.781&r2=1.782 That patch will be included in the next patch tarball. Thanks. |