Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 109546

Summary: broken ebuild : sys-apps/ucspi-tcp-0.88-r13
Product: Gentoo Linux Reporter: Aravind Srinivasan <aravinds>
Component: Current packagesAssignee: Qmail Team (OBSOLETE) <qmail-bugs+disabled>
Status: VERIFIED FIXED    
Severity: major CC: dennis.freise, matrixhax0r, sarpy.sam
Priority: High    
Version: unspecified   
Hardware: x86   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Aravind Srinivasan 2005-10-17 02:39:36 UTC
Patch 0.88-tcprules.patch added for bug#90679 breaks the build. Looks like the
code (tcprules.c) has changed independently, while the patch was being tested.
The  fix made by the patch seems to be there in the tcprules.c file. 

Reproducible: Always
Steps to Reproduce:
1.ACCEPT_KEYWORDS=~x86 emerge ucspi-tcp
2.
3.

Actual Results:  
* Failed Patch: 0.88-tcprules.patch !
 *  ( /usr/portage/sys-apps/ucspi-tcp/files/0.88-tcprules.patch )
 *
 * Include in your bugreport the contents of:
 *
 *   /var/tmp/portage/ucspi-tcp-0.88-r13/temp/0.88-tcprules.patch-12914.out

==============================================================================
/var/tmp/portage/ucspi-tcp-0.88-r13/temp/0.88-tcprules.patch-12914.out 

***** 0.88-tcprules.patch *****

===============================

PATCH COMMAND:  patch -p0 -g0 --no-backup-if-mismatch <
/usr/portage/sys-apps/ucspi-tcp/files/0.88-tcprules.patch

===============================
patching file tcprules.c
Hunk #1 FAILED at 127.
1 out of 1 hunk FAILED -- saving rejects to file tcprules.c.rej
===============================

PATCH COMMAND:  patch -p1 -g0 --no-backup-if-mismatch <
/usr/portage/sys-apps/ucspi-tcp/files/0.88-tcprules.patch

===============================
missing header for unified diff at line 3 of patch
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- tcprules.c.orig    2005-09-12 00:44:11.000000000 +0200
|+++ tcprules.c 2005-09-12 00:58:11.000000000 +0200
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
===============================

PATCH COMMAND:  patch -p2 -g0 --no-backup-if-mismatch <
/usr/portage/sys-apps/ucspi-tcp/files/0.88-tcprules.patch

===============================
missing header for unified diff at line 3 of patch
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- tcprules.c.orig    2005-09-12 00:44:11.000000000 +0200
|+++ tcprules.c 2005-09-12 00:58:11.000000000 +0200
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
===============================

PATCH COMMAND:  patch -p3 -g0 --no-backup-if-mismatch <
/usr/portage/sys-apps/ucspi-tcp/files/0.88-tcprules.patch

===============================
missing header for unified diff at line 3 of patch
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- tcprules.c.orig    2005-09-12 00:44:11.000000000 +0200
|+++ tcprules.c 2005-09-12 00:58:11.000000000 +0200
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
===============================

PATCH COMMAND:  patch -p4 -g0 --no-backup-if-mismatch <
/usr/portage/sys-apps/ucspi-tcp/files/0.88-tcprules.patch

===============================
missing header for unified diff at line 3 of patch
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- tcprules.c.orig    2005-09-12 00:44:11.000000000 +0200
|+++ tcprules.c 2005-09-12 00:58:11.000000000 +0200
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored


Expected Results:  
I guess 0.88-tcprules.patch can be dropped from the build

emerge sync done on October 17th

emerge info
Portage 2.0.53_rc5 (default-linux/x86/2005.1, gcc-3.3.5-20050130,
glibc-2.3.5-r2, 2.6.13-gentoo-r3 i686)
=================================================================
System uname: 2.6.13-gentoo-r3 i686 Intel(R) Pentium(R) 4 CPU 3.00GHz
Gentoo Base System version 1.12.0_pre9
dev-lang/python:     2.3.5, 2.4.2
sys-apps/sandbox:    1.2.13
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1
sys-devel/libtool:   1.5.20
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O3 -march=pentium4 -pipe -funroll-loops -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="..."
CONFIG_PROTECT_MASK="..."
CXXFLAGS="-O3 -march=pentium4 -pipe -funroll-loops -fomit-frame-pointer"
DISTDIR="/usr/distfiles"
FEATURES="autoconfig distlocks sandbox sfperms strict"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 X ..."
Unset:  ASFLAGS, CTARGET, LANG, LDFLAGS, LINGUAS
Comment 1 Michael Hanselmann (hansmi) (RETIRED) gentoo-dev 2005-10-17 05:04:16 UTC
I'll take a look this evening (CEST) or tomorrow.
Comment 2 Steven Coutts 2005-10-17 05:50:19 UTC
Compiles and installs fine on my machine.
Comment 3 Michael Hanselmann (hansmi) (RETIRED) gentoo-dev 2005-10-17 13:23:26 UTC
Please provide your full use flags, or at least the settings for those:
ucspi-tcp-0.88-r13.ebuild:IUSE="ssl ipv6 selinux doc"

It works for me, too, otherwise I wouldn't have commited it.
Comment 4 David Li 2005-10-17 15:55:28 UTC
Hmmm, my use flags:

USE="x86 7zip X a52 aac acl acpi aim alsa amarok amr apache2 artworkextra asm
avi bash-completion bitmap-fonts bl browserplugin bzip2 bzlib calendar
cdparanoia cdr crypt css cups curl custom-cflags dbus dhcp directfb divx4linux
doc dts dvd dvdread eds effects encode esd evo evo2 exif fbcon ffmpeg flac flash
foomaticdb fortran fping ftp gd gdbm gif glitz gnome gphoto2 gpm gstreamer gtk
gtk2 guile hal howl i8x0 icq imagemagick imap imlib imlib2 inkjar innodb irda
jabber java jikes jp2 jpeg junit libcaca libg++ libwww lzw mad matroska mhash
mikmod ming mmx mmxext mng motif mozdevelop mozilla moznocompose moznoirc
moznomail mozsvg mp3 mpeg mpi mplayer mpm-prefork msn musicbrainz mysql nas
nautilus ncurses network nfs nls nodoc nptl nsplugin offensive ogg oggvorbis
openal opengl openssh oscar pam pcre pdflib perl php pic png python quicktime
rar readline real reiserfs rtc samba sdl session slang sockets spell sse sse2
ssl stencil-buffer svg svga tcltk tcpd tetex tga threads tiff transcode truetype
truetype-fonts type1-fonts unicode usb vcd videos vim virus-scan visualization
vorbis wifi win32codecs wmf xml xml2 xpm xscreensaver xv xvid xvmc yahoo yv12
zip zlib userland_GNU kernel_linux elibc_glibc"

Confirm the bug too...
Comment 5 Aravind Srinivasan 2005-10-18 00:36:44 UTC
I know it works for a lot of people. It is equally strange for me that it works
for others. I couldn't figure out how the patch works for others. I went through
the patch and tcprules.c file. There is no line with "for (;;) {" in my
tcprules.c file. 
Let me know if any info or action is required from my side.

More info on what is happening on my system. 
When i 
1. comment out "epatch ${FILESDIR}/${PV}-tcprules.patch" 
2. do a ebuild ... digest  
3. emerge ucspi-tcp 
It works fine. I tried the tcprules command with file in bug#90679, and tcprules
 processed the file properly.

Use flags for ucspi-tcp ...
# emerge -pv ucspi-tcp

These are the packages that I would merge, in order:

Calculating dependencies ...done!
[ebuild   R   ] sys-apps/ucspi-tcp-0.88-r13  -doc -ipv6 (-selinux) +ssl 0 kB


emerge output after reverting back the changes...
# emerge ucspi-tcp
Calculating dependencies ...done!
>>> emerge (1 of 1) sys-apps/ucspi-tcp-0.88-r13 to /
>>> md5 files   ;-) ucspi-tcp-0.88-r12.ebuild
>>> md5 files   ;-) ucspi-tcp-0.88-r11.ebuild
>>> md5 files   ;-) ucspi-tcp-0.88-r9.ebuild
>>> md5 files   ;-) ucspi-tcp-0.88-r13.ebuild
>>> md5 files   ;-) ucspi-tcp-0.88-r10.ebuild
>>> md5 files   ;-) ucspi-tcp-0.88-r8.ebuild
>>> md5 files   ;-) files/digest-ucspi-tcp-0.88-r10
>>> md5 files   ;-) files/digest-ucspi-tcp-0.88-r11
>>> md5 files   ;-) files/digest-ucspi-tcp-0.88-r12
>>> md5 files   ;-) files/digest-ucspi-tcp-0.88-r13
>>> md5 files   ;-) files/0.88-limits.patch
>>> md5 files   ;-) files/0.88-tcprules.patch
>>> md5 files   ;-) files/0.88-head-1.patch
>>> md5 files   ;-) files/digest-ucspi-tcp-0.88-r8
>>> md5 files   ;-) files/digest-ucspi-tcp-0.88-r9
>>> md5 files   ;-) files/0.88-rblsmtpd-ignore-on-RELAYCLIENT.patch
>>> md5 files   ;-) files/0.88-bigendian.patch
>>> md5 files   ;-) files/tcprules-Makefile
>>> md5 files   ;-) files/0.88-errno.patch
>>> md5 src_uri ;-) ucspi-tcp-0.88.tar.gz
>>> md5 src_uri ;-) ucspi-rss.diff
>>> md5 src_uri ;-) ucspi-tcp-ssl-20020705.patch.gz
>>> Unpacking source...
>>> Unpacking ucspi-tcp-0.88.tar.gz to /var/tmp/portage/ucspi-tcp-0.88-r13/work
>>> Unpacking ucspi-rss.diff to /var/tmp/portage/ucspi-tcp-0.88-r13/work
unpack ucspi-rss.diff: file format not recognized. Ignoring.
>>> Unpacking ucspi-tcp-ssl-20020705.patch.gz to
/var/tmp/portage/ucspi-tcp-0.88-r13/work
 * Applying 0.88-errno.patch ...                                               
                                    [ ok ] * Applying
ucspi-tcp-ssl-20020705.patch ...                                               
                        [ ok ] * Applying ucspi-rss.diff ...                   
                                                                  [ ok ] *
Applying 0.88-head-1.patch ...                                                 
                                 [ ok ] * Applying
0.88-rblsmtpd-ignore-on-RELAYCLIENT.patch ...                                  
                        [ ok ] * Applying 0.88-limits.patch ...                
                                                                  [ ok ] *
Applying 0.88-tcprules.patch ...

 * Failed Patch: 0.88-tcprules.patch !
  ...
Comment 6 Michael Hanselmann (hansmi) (RETIRED) gentoo-dev 2005-10-18 03:30:20 UTC
Looks like the ipv6 USE flag makes the difference. Again, fixing this today evening.
Comment 7 Michael Hanselmann (hansmi) (RETIRED) gentoo-dev 2005-10-19 11:42:01 UTC
Fixed in CVS. The patch is only needed when compiling with USE=ipv6, as the
non-IPv6-version is unaffected. Can one of you test this please and then close
this bug?
Comment 8 Sarpy Sam 2005-10-19 17:20:47 UTC
I was having the exact issue described here and it now works using the CVS 
version. 
Comment 9 Aravind Srinivasan 2005-10-20 03:20:43 UTC
Did 
1. emerge sync
2. emerge ucspi-tcp

ucspi-tcp gets installed properly.

Closing the bug.