Summary: | Could reiserfsprogs display volume labels when doing fsck upon boot? | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Wiktor Wandachowicz <wiktorw> |
Component: | [OLD] Core system | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | VERIFIED UPSTREAM | ||
Severity: | enhancement | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
reiserfscore-prints.c-display_volume_label.diff
reiserfscore-prints.c-display_volume_label.diff with C-style comment reiserfscore-prints.c-display_volume_label.diff with correct C-style comment |
Description
Wiktor Wandachowicz
2005-10-13 09:00:47 UTC
Created attachment 70571 [details, diff]
reiserfscore-prints.c-display_volume_label.diff
The patch should be applied to the reiserfsprogs-3.6.19/reiserfscore/prints.c
in the unpacked source directory.
Comment on attachment 70571 [details, diff] reiserfscore-prints.c-display_volume_label.diff >620a621,624 >> /* Print volume label if it is non-empty. */ >> if (sb->s_label[0]) { >> reiserfs_warning (fp, "%s: ", sb->s_label); >> } Comment on attachment 70571 [details, diff] reiserfscore-prints.c-display_volume_label.diff >620a621,624 >> // Print volume label if it is non-empty. >> if (sb->s_label[0]) { >> reiserfs_warning (fp, "%s: ", sb->s_label); >> } 620a621,624 > /* Print volume label if it is non-empty. */ > if (sb->s_label[0]) { > reiserfs_warning (fp, "%s: ", sb->s_label); > } The above should change the print_super_block function, as following: /* return 1 if this is not super block */ int print_super_block (FILE * fp, reiserfs_filsys_t * fs, char * file_name, struct buffer_head * bh, int short_print) { struct reiserfs_super_block * sb = (struct reiserfs_super_block *)(bh->b_data); dev_t rdev; int format = 0; __u16 state; if (!does_look_like_super_block (sb)) return 1; rdev = misc_device_rdev(file_name); /* Print volume label if it is non-empty. */ if (sb->s_label[0]) { reiserfs_warning (fp, "%s: ", sb->s_label); } reiserfs_warning (fp, "Reiserfs super block in block %lu on 0x%x of ", bh->b_blocknr, rdev); switch (get_reiserfs_format (sb)) { Brr. Ugly. I can't figure out how to change the patch as I incorrectly put the C++ style comment instead of C-style. Patch resubmitted. Created attachment 70572 [details, diff]
reiserfscore-prints.c-display_volume_label.diff with C-style comment
Resubmitted the patch. Sorry for the mess... I'm still learning.
Created attachment 70573 [details, diff]
reiserfscore-prints.c-display_volume_label.diff with correct C-style comment
Aaaaahhhh! Wrong comment again! I suppose this will be thrown out of the
window...
Resubmitted the patch.
Why don't you take this upstream (reiserfs-list@namesys.com)? yeah, this isnt something to add to Gentoo I think you're right. I'll try to post that upstream. Well, I did what I could. See here: http://article.gmane.org/gmane.comp.file-systems.reiserfs.general/16553 http://news.gmane.org/gmane.comp.file-systems.reiserfs.general A small discussion started which also touched ReiserFS v.4 and its handling of volume labels. Good to know that it may incorporate my desired behaviour one day too. Even though I don't use it right now. And at the end Vitaly Fertman (the developer) said he will apply my patch. Finally in the PM he said that's already done. Very, very nice :-) Now all that's left is to wait for updated version of reiserfsprogs. Thanks for the motivation, jakub && vapier !! |