| Summary: | media-gfx/xv-3.10a-r12 build fails if USE=jpeg is not specified | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | tar |
| Component: | Current packages | Assignee: | Tavis Ormandy (RETIRED) <taviso> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | A patch to the patch to fix the error | ||
Created attachment 70456 [details, diff]
A patch to the patch to fix the error
Thanks Tim, I've checked in your fix into cvs. Marking fixed. |
Emerging xv-3.10a-r12 fails with a compliation error if the "jpeg" USE variable is not enabled: i686-pc-linux-gnu-gcc -march=pentium4 -O2 -fomit-frame-pointer -fno-ident -pipe -mfpmath=sse -msse2 -DUSE_GETCWD -DLINUX -DUSLEEP -DDOPNG -DDOTIFF -DUSE_TILED_TIFF_BOTLEFT_FIX -I/usr/include -DDOPDS -DMGCSFXDIR=\"/usr/local/lib/xv\" -DSYSCONFDIR=\"/usr/local/etc\" -DXVEXECPATH=\"/usr/local/lib/xv\" -c xvimage.c xvevent.c: In function `HandleEvent': xvevent.c:640: error: `wasJpegUp' undeclared (first use in this function) xvevent.c:640: error: (Each undeclared identifier is reported only once xvevent.c:640: error: for each function it appears in.) make: *** [xvevent.o] Error 1 make: *** Waiting for unfinished jobs.... !!! ERROR: media-gfx/xv-3.10a-r12 failed. !!! Function src_compile, Line 68, Exitcode 2 This is due to an error in the xv-3.10a-jumbo-enh-patch-20050501.txt patch. This snippet from that patch file contains the error (lines 7505 - 7507): +#ifdef HAVE_PNG + if (wasPngUp) { PNGDialog(wasJpegUp); wasPngUp=0; } +#endif The second line is referencing the wrong variable. It should be: +#ifdef HAVE_PNG + if (wasPngUp) { PNGDialog(wasPngUp); wasPngUp=0; } +#endif Reproducible: Always Steps to Reproduce: 1. export USE=-jpeg emerge media-gfx/xv Actual Results: The compilation failed: i686-pc-linux-gnu-gcc -march=pentium4 -O2 -fomit-frame-pointer -fno-ident -pipe -mfpmath=sse -msse2 -DUSE_GETCWD -DLINUX -DUSLEEP -DDOPNG -DDOTIFF -DUSE_TILED_TIFF_BOTLEFT_FIX -I/usr/include -DDOPDS -DMGCSFXDIR=\"/usr/local/lib/xv\" -DSYSCONFDIR=\"/usr/local/etc\" -DXVEXECPATH=\"/usr/local/lib/xv\" -c xvimage.c xvevent.c: In function `HandleEvent': xvevent.c:640: error: `wasJpegUp' undeclared (first use in this function) xvevent.c:640: error: (Each undeclared identifier is reported only once xvevent.c:640: error: for each function it appears in.) Expected Results: The compliation should succeed even if JPEG support is not enabled. Portage 2.0.51.22-r3 (hardened/x86/2.6, gcc-3.4.4, glibc-2.3.5-r2, 2.6.11-hardened-r15 i686) ================================================================= System uname: 2.6.11-hardened-r15 i686 Intel(R) Xeon(TM) CPU 2.80GHz Gentoo Base System version 1.6.13 dev-lang/python: 2.3.5-r2, 2.4.1-r1 sys-apps/sandbox: 1.2.12 sys-devel/autoconf: 2.13, 2.59-r6 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1 sys-devel/binutils: 2.15.92.0.2-r10 sys-devel/libtool: 1.5.18-r1 virtual/os-headers: 2.6.8.1-r1, 2.6.11-r2 ACCEPT_KEYWORDS="x86" AUTOCLEAN="yes" CBUILD="i686-pc-linux-gnu" CFLAGS="-march=pentium4 -O2 -fomit-frame-pointer -fno-ident -pipe -mfpmath=sse -msse2" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d" CXXFLAGS="-march=pentium4 -O2 -fomit-frame-pointer -fno-ident -pipe -mfpmath=sse -msse2" DISTDIR="/usr/portage/distfiles" FEATURES="autoconfig distlocks fixpackages sandbox sfperms strict userpriv" GENTOO_MIRRORS="http://gentoo.chem.wisc.edu/gentoo/ ftp://ftp.ussg.iu.edu/pub/linux/gentoo/ http://cudlug.cudenver.edu/gentoo/ http://mirrors.tds.net/gentoo/ http://csociety-ftp.ecn.purdue.edu/pub/gentoo/" LDFLAGS="-Wl,-O1" MAKEOPTS="-j5" PKGDIR="/usr/portage//packages/x86/" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage/" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="X acpi alsa apache2 arts berkdb cdr crypt cups curl dga dlloader doc dvd dvdr eds esd evo fam flac foomaticdb gd gdbm gif gnome gpm gstreamer gtk gtk2 hal hardened imagemagick imap imlib kde kdeenablefinal ldap libwww mad mbox mikmod mmx mmx2 motif mozilla ncurses nls nptl offensive ogg opengl pam pda pdflib perl pic png ppds python qt readline samba sasl sdl slang slp snmp sse ssl svga tcltk tcpd tiff truetype usb userlocales vorbis wifi win32codecs x86 xface xine xinerama xml2 xmms xprint xv xvid zlib userland_GNU kernel_linux elibc_glibc" Unset: ASFLAGS, CTARGET, LANG, LC_ALL, LINGUAS