Bug 10872 – cvs.eclass doesnt like whitespace in module names

• Product: Portage Development
• Status: RESOLVED FIXED

[Description Georgi Georgiev 2002-11-17 08:16:25 UTC]

I am trying to write an ebuild for the HT Editor (http://hte.sf.net)
My ebuild uses the CVS version, but unfortunately the cvs module of the editor
is named "HT Editor" which gives a lot of errors with a lot of functions that
are part of portage, where an environment variable doesn't have quotes around it.

Should I send a patch with my changes to ebuild.sh and cvs.eclass for now (i
only fixed stuff until I got my ebuild working)?

[Comment 1 Georgi Georgiev 2002-11-17 18:07:59 UTC]

it is not only cvs.eclass that has problems.

/usr/sbin/ebuild.sh has problems too, when $S has whitespace... which has only
been triggered when using "inherit cvs" for now.

[Comment 2 Dan Armak (RETIRED) 2002-11-21 09:55:14 UTC]

Since you've done the necessary changes, a diff would be nice. Attach your cvs 
ebuild too so I can test those fixes on something that needs them. 

[Comment 3 Georgi Georgiev 2002-11-21 13:01:12 UTC]

I don't know if mine are the "necessary" changes, since I only made enough
changes to get it working for me only...., but there they go next. BTW, an
emerge sync wrote over my cvs.eclass, so I just edited it again and typos are
possible. My cvs.eclass is now safe in $PORTDIR_OVERLAY (that's the correct way
to do it, right?).

[Comment 4 Georgi Georgiev 2002-11-21 13:01:54 UTC]

Created attachment 5853 [details, diff]
cvd.eclass and ebuild.sh patch

[Comment 5 Georgi Georgiev 2002-11-21 13:03:41 UTC]

should I resubmit that patch in two pieces?

[Comment 6 Dan Armak (RETIRED) 2002-11-23 15:37:56 UTC]

Please submit the ebuild.sh part as a new bug because I'm not the person who 
should commit those changes. 
 
I'll commit the changes to cvs.eclass (by hand not from your patch - I'm just putting 
quotes around all directory/file names that have variables in them). Tell me if the new 
cvs.eclass is ok. I've been conservative in my changes, so in a few places you may 
find it necessary to add some more quotes, if so tell me. 

[Comment 7 Georgi Georgiev 2002-11-23 17:33:29 UTC]

Still having problems

I will submit a diff between my cvs.eclass and the one that is almost fixed.
There are three more corrections that need to be done:

1: line 288 - you have the "*" inside the quotes. This will not work. The * has
to be outside the quotes. ls "/*" usualy says "ls: /*: No such file or directory"

2: line 294 - same as above.

3: Line 303: $DIR need some escaped quotes -> "`ls -A \"$DIR\"`"

Now it works.

[Comment 8 Georgi Georgiev 2002-11-23 17:35:04 UTC]

Created attachment 5902 [details, diff]
patch against cvs.eclass 2002-11-24 06:50:19

[Comment 9 Dan Armak (RETIRED) 2002-11-30 13:44:45 UTC]

I've added the first 2 fixes a few days ago, and now the third one. So, this can be 
closed. Thanks for reporting :-) 

[Comment 10 Georgi Georgiev 2002-12-01 09:27:23 UTC]

I just "emerge sync"-ed and then "emerge"-ed my hteditor ebuild and it seems to
have worked fine. BTW, I hadn't paid enough attention to your first comment. You
probably don't need my ebuild anymore, but I decided it would be nice to submit
it anyway. Check bug 11447 if you still want to take a look at something that
needed the fixes.