Summary: | XMMS-arts volumesetting problems. | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ulrik Mikaelsson <ulmi01> |
Component: | Current packages | Assignee: | Gentoo KDE team <kde> |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | 1.4_rc1 | ||
Hardware: | x86 | ||
OS: | Linux | ||
URL: | http://www.xmms.org | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
A patch to fix various volume setting issues of the xmms-arts plugin.
xmmsarts-0.4-debian-rev-21.diff.gz (debian-specific parts stripped out) Volume fix non-linear volume |
Description
Ulrik Mikaelsson
2002-11-16 21:41:02 UTC
Created attachment 5740 [details, diff]
A patch to fix various volume setting issues of the xmms-arts plugin.
This is my proposed patch.
I would also like to point out that I have sent the same bugreport / patch to www.xmms.org Here is a link: http://bugs.xmms.org/show_bug.cgi?id=1107 xmms-arts being unmaintained, this patch must be very well tested before going into portage. Only I don't have the time for that now :-( I looked among other distros and found debian's patch (attaching in case anyone's interested), which is almost 100k long when uncompressed and seems to fix lots of small issues. However it only touches about.c, the rest is changes to the build system. Created attachment 7760 [details]
xmmsarts-0.4-debian-rev-21.diff.gz (debian-specific parts stripped out)
It's been used by myself and two buddies running gentoo for a couple of months now, without any problems. The only setback for his patch as I see it is slightly more cpu usage, but nothing that should not be a problem for anyone running KDE. :-) Actually I've added an extra feature, square volume increase instead of linear. If anyone is interested I'm attaching the new patch. Created attachment 7763 [details, diff]
Volume fix non-linear volume
This is all really well... however I do not really wish to have a package that's officially dead mainstream in portage. (And noone has agreed to officially maintain it, there might be other loal patches/fixes like these elsewhere for all we knbow and there's noone to coordinate them). Sooner or later it'll break and then it would be my responsibility to fix it without an upstream author I could ask for help, and I don't want that. So I've resolved to mask xmms-arts (permanently unless and until someone says he's willing to actively maintain it). OTOH this means that I will now add these patches to it. But it won't be visible as a package. Sorry... I'll get confirmation from -core and do this in a day or two. Oh and in case anyone wonders, this will be 'hard-masked' and not put in ~ profiles because (contrary to a common misunderstanding) those are not for unstable stuff but for untested stuff. Things in ~ go semiautomatically into stable profiles after a week or two if there are no known issues. xmms-arts has been hardmasked. |