Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 108196

Summary: Patch to autoload acpi modules on acpid start
Product: Gentoo Linux Reporter: Bharath Ramesh <krosswindz>
Component: [OLD] UnspecifiedAssignee: Mobile Herd (OBSOLETE) <mobile+disabled>
Status: RESOLVED WONTFIX    
Severity: enhancement CC: seyko2
Priority: High    
Version: unspecified   
Hardware: x86   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: patch for gentoo acpid initscript
/etc/conf.d/acpid configuration file for acpid initscript

Description Bharath Ramesh 2005-10-05 10:11:41 UTC
The patch attached with this bug reports facilitates the autoloading of acpi
modules when acpid is started. Distros like debian autoload the acpi modules. I
have adapted the module loading section of debian initscript into acpid
initscript of gentoo to facilitate the module autoloading feature.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Bharath Ramesh 2005-10-05 10:12:30 UTC
Created attachment 69928 [details, diff]
patch for gentoo acpid initscript
Comment 2 Bharath Ramesh 2005-10-05 10:13:17 UTC
Created attachment 69930 [details]
/etc/conf.d/acpid configuration file for acpid initscript
Comment 3 Henrik Brix Andersen 2005-10-05 13:52:12 UTC
Module loading should not be done by each and every init script. Implementing 
a module loader in many init scripts is error prone and causes code 
duplication.

Instead, correct module aliases should be made so that the kernel can autoload 
modules as needed, the drivers should be compiled statically into the kernel 
or the /etc/modules.autoload.d/kernel-2.{4,6} files should be used for 
autoloading the needed modules at boot time.

Yes, I am aware that we have multiple init scripts which does load modules, 
mostly because of upstream policy.
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2007-04-09 13:29:12 UTC
*** Bug 173910 has been marked as a duplicate of this bug. ***
Comment 5 Sergey Ya. Korshunoff 2007-04-09 13:54:58 UTC
(In reply to comment #3)
> Module loading should not be done by each and every init script. Implementing 
> a module loader in many init scripts is error prone and causes code 
> duplication.
> 
> Instead, correct module aliases should be made so that the kernel can autoload 
> modules as needed, the drivers should be compiled statically into the kernel 
> or the /etc/modules.autoload.d/kernel-2.{4,6} files should be used for 
> autoloading the needed modules at boot time.
> 
> Yes, I am aware that we have multiple init scripts which does load modules, 
> mostly because of upstream policy.

1) kernel/drivers/acpi/* modules can not be loaded aotomaticaly with any aliases
2) what you suggest to place in /etc/modules.autoload.d/kerenl* ? We do not know how many modules are in kernel/drivers/acpi/*
3) Why you restrict to compile all "kernel/drivers/acpi/*" staticaly in kernel?
 Where there is wiki about acpid policy?
4) Why /etc/init.d/autoconfig then go to load this modules? Why this feature not removed from there?
Comment 6 Jakub Moc (RETIRED) gentoo-dev 2007-04-09 14:18:29 UTC
*** Bug 173910 has been marked as a duplicate of this bug. ***
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2007-04-09 15:06:02 UTC
*** Bug 173910 has been marked as a duplicate of this bug. ***
Comment 8 Jakub Moc (RETIRED) gentoo-dev 2007-04-09 15:28:39 UTC
*** Bug 173910 has been marked as a duplicate of this bug. ***
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2007-04-09 15:36:58 UTC
*** Bug 173910 has been marked as a duplicate of this bug. ***
Comment 10 Sergey Ya. Korshunoff 2007-04-09 15:49:20 UTC
(In reply to comment #9)
> *** Bug 173910 has been marked as a duplicate of this bug. ***

> So, if you really want to make me angry, touch this bug one more time. Move to
> the original bug and stop bugspamming innocent people!

It is strange policy to cover bugs closed... We found your report is a duplicate.
But duplicate is closed. Withount any good resone. Without any way to reaopen original bug. Making good data for a Gentoo Weekly News open bugs statistics.

I have impression than this is not a correct way to make things better
Comment 11 Jakub Moc (RETIRED) gentoo-dev 2007-04-09 16:27:02 UTC
(In reply to comment #10)
> It is strange policy to cover bugs closed... We found your report is a
> duplicate.

If you have nothing useful to add to the topic here, then there's no need to comment.

> But duplicate is closed. Withount any good resone. 
 
I really fail to see what's so horribly unclear about the statement that acpid init script in NOT a correct place to load kernel ACPI modules? How about all the people that don't have acpid installed at all (majority of users), how exactly will this initscript help them? You are 'fixing' things at a completely wrong place.