| Summary: | rox.eclass enhancements and fixups | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Peter Hyman <pete4abw> |
| Component: | [OLD] Core system | Assignee: | Sergey Kuleshov (RETIRED) <svyatogor> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
rox.eclass
rox.eclass.patch rox.eclass |
||
Created attachment 69901 [details]
rox.eclass
Updated rox.eclass file
Created attachment 69902 [details, diff]
rox.eclass.patch
Patch against current rox.eclass that is in portage.
Created attachment 71796 [details]
rox.eclass
many new fixes. Removes SET_PERM requirement for ebuilds since it is set
internally in the eclass. Adds a new KEEP_SRC variable which when set, will
preserve the src directory since sometimes users like to keep it :). Currently,
it is removed in rox_src_compile by default. In addition, all variable
references have been corrected to be in the ${VARIABLE} format. Extra quotes
that appeared in if [ ... ] statements to bracket the variables have been
removed to avoid unnecessary clutter. Thus, if [ -n "$ROX_CLIB_VER" ] is now if
[ -n ${ROX_CLIB_VER} ]. This is consistent with gentoo specs.
Thank you for great job! |
Cleaned up code so all $variables have {} around them, eg ${variables} throughout eclass. Added credit. Added code to automatically set the SET_PERM flag if an Application's src/ directory exists. This will save users the trouble of having to remember to add SET_PERM=true when creating ebuilds and prevent errors that keep programs from running since the executable won't be marked 0755 without it! Also, cleaned up language at the end in pkg_postinst. Both full file and patch against current version are attached