Bug 107571

Summary:	Alternative way to disable KDE_ENABLE_HIDDEN_VISIBILITY in kde.eclass
Product:	Gentoo Linux	Reporter:	Gregorio Guidi (RETIRED) <greg_g>
Component:	[OLD] KDE	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED FIXED
Severity:	enhancement
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	kde-disable-visibility.patch

Description Gregorio Guidi (RETIRED) gentoo-dev

2005-09-29 01:46:00 UTC

Hi, 
I would like to commit a patch to kde.eclass that replaces the current way we 
disable the gcc visibility support in the KDE build system. 
 
At the moment we remove the line with KDE_ENABLE_HIDDEN_VISIBILITY from 
configure.in.ins and regenerate configure. 
What the patch does is just setting 
'export kde_cv_prog_cxx_fvisibility_hidden=no' 
before running ./configure, which has the same effect (at least in my 
tests...) 
 
In this way we don't waste a lot of time by running autotools and we avoid the 
error-prone method of sedding configure.in.in (as shown by bug 107318). 
 
Can you give it a try and see if it's ok? I would like to commit the patch in 
a few days...

Comment 1 Gregorio Guidi (RETIRED) gentoo-dev

2005-09-29 01:47:42 UTC

Created attachment 69468 [details, diff]
kde-disable-visibility.patch

Comment 2 Marcus D. Hanwell (RETIRED) gentoo-dev

2005-10-01 08:39:53 UTC

That seems like a better way to do it to me too - the current way is causing 
configure failures for packages that worked fine before due to their buggy 
configure.in.in and stuff.

Comment 3 Gregorio Guidi (RETIRED) gentoo-dev

2005-10-03 01:03:06 UTC

No bad feedback... I committed the change now.