Bug 106774

Summary:	rox.eclass fails to byte compile all python modules
Product:	Gentoo Linux	Reporter:	Peter Hyman <pete4abw>
Component:	Eclasses	Assignee:	Sergey Kuleshov (RETIRED) <svyatogor>
Status:	RESOLVED FIXED
Severity:	major	Keywords:	Inclusion
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	rox.eclass cumulative patch rox.eclass file rox.eclass.cumulative.patch rox.eclass

Description Peter Hyman 2005-09-21 03:56:42 UTC

All ROX applications have py files. When first run, python will attempt to byte
compile them. However, since users don't have w permission in the ROX, they do
not compile and are interpreted. While this does not seem to affect
functionality, ROX ebuilds should provide users with byte compiled files at
install time. The attached patch includes patches from bug #106253 and includes
the python code from the python.eclass to create the pyc and pyo files. I mark
this as a major bug since without these changes, ROX does not fully compile its
packages.

Comment 1 Peter Hyman 2005-09-21 03:58:16 UTC

Created attachment 68927 [details, diff]
rox.eclass cumulative patch

Comment 2 Jakub Moc (RETIRED) gentoo-dev

2005-09-21 03:59:22 UTC

*** Bug 106253 has been marked as a duplicate of this bug. ***

Comment 3 Peter Hyman 2005-09-21 04:35:01 UTC

Just a note on the duplicate marking for bug #106253. That bug noted a different
problem of the eclass NOT handling the chmod a+x for AppRun or AppletRun files
in subdirectories under the main Application dir. That patch (included here)
uses the find command to recurse through all subdirs. This occured with the
Oroborox (see bug #106247) and MusicBox (see bug #100426)applications for
example. These apps will fail if the AppRun files in subdirs are not changed as
per this eclass patch.

Comment 4 Peter Hyman 2005-09-21 11:20:41 UTC

Created attachment 68948 [details]
rox.eclass file

Full rox.eclass file with patch applied. Required for new rox ebuilds.

Comment 5 Peter Hyman 2005-09-23 03:10:29 UTC

Created attachment 69059 [details, diff]
rox.eclass.cumulative.patch

Made some additional changes and cleanups (corrected spelling, changed chmod
code to be consistent (i.e. 0755 -> a+x, 755 -> a+x). Added >/dev/null 2>&1 to
python byte compile code to shush errors.

Comment 6 Peter Hyman 2005-09-23 03:11:09 UTC

Created attachment 69060 [details]
rox.eclass

Updated rox.eclass file

Comment 7 Sergey Kuleshov (RETIRED) gentoo-dev

2005-09-25 04:06:46 UTC

in cvs. thak you for great job and valuable updates.

P.S. I reverted back a+x -> 755 though ;)