Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 106457

Summary: mysql and pgsql passdb backends broken in samba 3.0.20, patches attached
Product: Gentoo Linux Reporter: Uli M <a.sporto+gen>
Component: Current packagesAssignee: Gentoo's SAMBA Team <samba>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 109174    
Bug Blocks:    
Attachments: resolves add user problem(missing fields in INSERTs) and UPDATE problem(missing where clause due to bug in talloc)
resolves pdbedit -L segfaults (setsampwent frees results before ever using them)

Description Uli M 2005-09-18 18:04:59 UTC
Be sure not to use these backends without the attached patches. An example:
changing someone's password results in ALL users having that new
password(UDPATEs miss the where clause).

I'm filing this to spare other people the trouble.
I'm (at least till now) only a portage user but I managed to get an ebuild
working with the attached two patches, just changed

<       epatch ${PATCHDIR}/general
---
>       epatch ${PATCHDIR}/general ${FILESDIR}

and added the attached patches to the files dir.
They solve the currently reported bugs(see bugzilla.samba.org) with the mysql
and pgsql passdb backends.
Comment 1 Uli M 2005-09-18 18:08:04 UTC
Created attachment 68781 [details, diff]
resolves add user problem(missing fields in INSERTs) and UPDATE problem(missing where clause due to bug in talloc)
Comment 2 Uli M 2005-09-18 18:09:03 UTC
Created attachment 68782 [details, diff]
resolves pdbedit -L segfaults (setsampwent frees results before ever using them)
Comment 3 Christian Andreetta (RETIRED) gentoo-dev 2005-09-19 02:29:58 UTC
Thanks. Which are the upstream bug numbers in bugzilla.samba.org?
Comment 4 Uli M 2005-09-19 06:32:35 UTC
(In reply to comment #3)
> Thanks. Which are the upstream bug numbers in bugzilla.samba.org?

Fixes 2531, 3018, 3111

About samba bug 3019: examples/pdb/mysql/mysql.dump is wrong, at least
logon_hours is missing. In the bug's comments two schemas are proposed but since
I'm using pgsql(for which there isn't an example at all) I can't check them out.
Comment 5 Christian Andreetta (RETIRED) gentoo-dev 2005-10-14 05:28:16 UTC
Postgres: 2531, 3018 and 3111 are already fixed upstream (at least) for
samba-3.0.20b.
Mysql: the schema in https://bugzilla.samba.org/show_bug.cgi?id=3019 is still
pending. Including in 3.0.20b release
Comment 6 Christian Andreetta (RETIRED) gentoo-dev 2005-10-14 06:34:38 UTC
3.0.20b in portage. Thanks