Bug 106140

Summary:	sys-process/atop init script failure (syntax errors) v1.13
Product:	Gentoo Linux	Reporter:	Chad A. Simmons <chad.simmons>
Component:	New packages	Assignee:	Gentoo Linux bug wranglers <bug-wranglers>
Status:	RESOLVED TEST-REQUEST
Severity:	minor
Priority:	High
Version:	unspecified
Hardware:	AMD64
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Chad A. Simmons 2005-09-15 20:13:05 UTC

chadgentoo ~ # /etc/init.d/atop start
/etc/init.d/atop: line 22: syntax error near unexpected token `fi'
/etc/init.d/atop: line 22: `    fi'
 * ERROR:  "/etc/init.d/atop" has syntax errors in it; not executing...


Reproducible: Always
Steps to Reproduce:
1. emerge atop
2. /etc/init.d/atop start
3.

Actual Results:  
chadgentoo ~ # /etc/init.d/atop start
/etc/init.d/atop: line 22: syntax error near unexpected token `fi'
/etc/init.d/atop: line 22: `    fi'
 * ERROR:  "/etc/init.d/atop" has syntax errors in it; not executing...

Expected Results:  
started atop init script.

chadgentoo ~ # emerge info
Portage 2.0.51.22-r2 (default-linux/amd64/2005.0, gcc-3.4.4, glibc-2.3.5-r1,
2.6.13-gentoo-r1 x86_64)
=================================================================
System uname: 2.6.13-gentoo-r1 x86_64 AMD Athlon(tm) 64 Processor 3700+
Gentoo Base System version 1.6.13
ccache version 2.3 [enabled]
dev-lang/python:     2.3.5-r2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6
sys-devel/binutils:  2.15.92.0.2-r10
sys-devel/libtool:   1.5.18-r1
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="amd64"
AUTOCLEAN="yes"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=k8 -msse3 -pipe -O2"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env
/usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/lib64/mozilla/defaults/pref /usr/share/config
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/splash /etc/terminfo /etc/env.d"
CXXFLAGS="-march=k8 -msse3 -pipe -O2"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://distfiles.gentoo.org
http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="amd64 X a52 aac aalib acpi alsa apm avi bash-completion berkdb bitmap-fonts
bonobo cdr crypt css cups curl dts dvd dvdr dvdread eds emboss encode esd
extensions fam ffmpeg foomaticdb fortran gd gdbm gif gnome gpm gstreamer gtk
gtk2 gtkhtml hal imagemagick imlib ipv6 java jpeg kde kdenablefinal lm_sensors
lzo lzw lzw-tiff mad mjpeg mozilla mp3 mpeg ncurses nls nvidia offensive ogg
opengl oss pam pdflib perl png python qt quicktime readline rtc scanner sdl
session spell ssl tcltk tcpd tiff truetype-fonts type1-fonts usb userlocales
vorbis xine xml xml2 xpm xv xvid xvmc zlib userland_GNU kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS, MAKEOPTS, PORTDIR_OVERLAY

Comment 1 Chad A. Simmons 2005-09-15 20:20:52 UTC

can someone commit this patch to the rsync servers? This fixes the problem.

chadgentoo ~ # cat atop.patch
20c20
<       if [ "$PIDATOP" != "" ]
---
>       if [ "$PIDATOP" != "" ]; then

Comment 2 Chad A. Simmons 2005-09-19 04:38:24 UTC

Can someone test/commit this patch to the init script?