Bug 104748 – dev-util/cvsps 2.1 is stable on amd64

• Product: Gentoo Linux
• Status: RESOLVED CANTFIX

[Description Joshua Hoblitt 2005-09-03 14:54:34 UTC]

I've been using it for a couple of months without any failures.  Please mark it
stable on amd64.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Luis Medinas (RETIRED) 2005-09-04 15:09:33 UTC]

We cannot mark stable until the maintainer mark it stable first.
Thanks anyway for the report

[Comment 2 Joshua Hoblitt 2005-09-05 17:12:41 UTC]

OK - I use it on my laptop as well, which is x86, so I'll ask it to be marked
stable on x86 then reopen this bug.

[Comment 3 Bertrand Jacquin 2006-05-18 02:56:26 UTC]

And it is not stable.

See : http://marc.theaimsgroup.com/?t=114791418600003&r=1&w=2
http://marc.theaimsgroup.com/?l=git&m=114793114627212&w=2

Problem is :
connect error: Network is unreachable
WARNING: malformed CVS version str: Server:
WARNING: Your CVS client version:
[Client: Concurrent Versions System (CVS) 1.12.12 (client)]
and/or server version:
[Server: ]
are too old to properly support the rlog command.
This command was introduced in 1.11.1.  Cvsps
will use log instead, but PatchSet numbering
may become unstable due to pruned empty
directories.

cvs [log aborted]: end of file from server (consult above messages if any)

Address resolution is broken in cvsps on 64-bit machines.  This patch to
cvsps is needed:

--- cbtcommon/tcpsocket.c
+++ cbtcommon/tcpsocket.c
@@ -198,7 +198,7 @@ convert_address(long *dest, const char *
     memcpy(dest, &ip.s_addr, sizeof(ip.s_addr));
   }
 #else
-  if ( (*dest = inet_addr(addr_str)) != -1)
+  if ( (*dest = inet_addr(addr_str)) != INADDR_NONE)
   {
     /* nothing */
   }