Bug 103433

Summary:	misleading mldonkey rc-status upon failure on daemon startup
Product:	Gentoo Linux	Reporter:	Mehmet Giritli <mehmet>
Component:	New packages	Assignee:	Gentoo net-p2p team <net-p2p>
Status:	RESOLVED FIXED
Severity:	normal	CC:	spiralvoice
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	MLdonkey init script

Description Mehmet Giritli 2005-08-23 03:47:33 UTC

when mldonkey daemon is attempted with /etc/init.d/mldonkey but the startup did
not occur because of some failure (e.g. existing .pid file), the rc-status of
mldonkey still becomes `started' although it is not. In such a situation,
rc-status of mldonkey sould be `off'.

Comment 1 spiralvoice 2005-08-25 08:57:36 UTC

Please try this patch and report if it improves the MLDonkey core behaviour:
https://savannah.nongnu.org/patch/index.php?func=detailitem&item_id=4347

Comment 2 Mehmet Giritli 2005-08-25 14:07:32 UTC

Created attachment 66888 [details]
MLdonkey init script

Comment 3 Mehmet Giritli 2005-08-25 14:11:26 UTC

Your patch went smoothly over 2.6.3 and compiled fine. However did not solve the
problem. A quick examination of the init script showed that the problem was
there.    Attachment puts the missing line of `return 1' in the appropriate
location. Works fine here.

Comment 4 spiralvoice 2005-08-25 15:28:11 UTC

(In reply to comment #3)
> Your patch went smoothly over 2.6.3 and compiled fine. However did not solve the
> problem. 
hehe, so there were two errors. One in the ini script, but MLDonkey also returned
exit code zero on some errors, so my patch is still necessary.

Could you please debug the error codes a bit?
* start MLDonkey twice so the second MLDonkey exits with a message about blocked
ports
* chmod temp directory (or another one) so MLDonkey can

Comment 5 spiralvoice 2005-08-25 15:28:11 UTC

(In reply to comment #3)
> Your patch went smoothly over 2.6.3 and compiled fine. However did not solve the
> problem. 
hehe, so there were two errors. One in the ini script, but MLDonkey also returned
exit code zero on some errors, so my patch is still necessary.

Could you please debug the error codes a bit?
* start MLDonkey twice so the second MLDonkey exits with a message about blocked
ports
* chmod temp directory (or another one) so MLDonkey can´t write to it and start
the core
* set system date into the year 2004 and start MLDonkey

Comment 6 spiralvoice 2005-09-03 17:06:06 UTC

MLDonkey 2.6.4 with this patch was released today.

Comment 7 Marcin Kryczek (RETIRED) gentoo-dev

2005-09-18 06:13:04 UTC

fixed in cvs. thanks