Bug 103396 – make kernel checks in ppp non-fatal

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description SpanKY 2005-08-22 17:54:19 UTC]

unless i'm mistaken, the ppp package does not need the PPP features of the
kernel enabled in order to compile properly, so please disable this check in
pkg_setup

[Comment 1 Alin Năstac (RETIRED) 2005-08-22 20:36:39 UTC]

yes, but it needs CONFIG_PPP in order to run properly.
shouldn't we check basic kernel support for programs like this?

[Comment 2 SpanKY 2005-08-23 06:23:23 UTC]

you can check and *warn*, but not check and *die*

[Comment 3 Henrik Brix Andersen 2005-08-27 02:57:44 UTC]

Why not check and die? If the package needs the kernel option to be present in
order to work correctly...

[Comment 4 Stefan Briesenick (RETIRED) 2005-08-28 02:53:36 UTC]

because it's some kind of RDEPEND (not DEPEND).  
  
You can change your kernel options whenever you want and your package will be  
broken (or fixed) then. Reboot with another kernel and everything is different.  
  
Unfortunately, there's 'linux-info_pkg_setup' in linux-info.eclass with hard  
die if CONFIG_* options doesn't match, but no check-only with some 'ewarn'  
output.  
  
I have the same problem with my capi4k-utils and isdn4k-utils packages. I want  
to check the kernel options, so I can inform the user that the current options  
are not ok, but I don't want to stop the emerge.  
  
Check & die is only ok if you're compiling kernel-modules (then it's a DEPEND).  
 

[Comment 5 Alin Năstac (RETIRED) 2005-09-22 16:04:45 UTC]

fixed in cvs. also, tests are now performed in pkg_postinst.
if you have better info messages regarding this subject, please let me know.