Bug 103267

Summary:	Patch to remove possibly offensive material from xscreensaver
Product:	Gentoo Linux	Reporter:	Tim Redman <tim>
Component:	Current packages	Assignee:	Krzysztof Pawlik (RETIRED) <nelchael>
Status:	RESOLVED FIXED
Severity:	enhancement
Priority:	High
Version:	unspecified
Hardware:	x86
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch to remove webcollage module when "offensive" USE flag is set Patch to xscreensaver-4.22-r4.ebuild to apply previous patch. xscreensaver-4.22-nsfw-webcollage.patch

Description Tim Redman 2005-08-21 10:59:42 UTC

There has been some question in the past if the webcollage module of
xscreensaver could contain potentially offensive content.  Since is crawls the
web for random images, and the web has a reputation for having its shadier
sides, this is bound to be a possibility.

This patch is an addendum to the NSFW (not suitable for work) patch made
originally in 4.16.  Instead of adding to that patch, and possibly breaking
emerges before 4.22, I've included this as a separate patch.  Also included is a
patch for the ebuild itself.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.



Expected Results:  
This patch removes the webcollage module from the build, provided that the
"offensive" USE flag is set.

This is only my second ebuild/patch ever, so take any effectiveness of this
revision with a grain of salt.  Any input from more seasoned developers would be
most appreciated.

Patches to follow in the next few comments.

Comment 1 Tim Redman 2005-08-21 11:02:08 UTC

Created attachment 66488 [details, diff]
Patch to remove webcollage module when "offensive" USE flag is set

Since this also removes i18n strings from .po files, this patch may be a little
bit overkill, but I wanted to make sure I didn't miss anything.  However,
because of the number of files this patches, any testing input would be
appreciated.

Comment 2 Tim Redman 2005-08-21 11:04:15 UTC

Created attachment 66489 [details, diff]
Patch to xscreensaver-4.22-r4.ebuild to apply previous patch.

Comment 3 Krzysztof Pawlik (RETIRED) gentoo-dev

2005-10-01 01:25:13 UTC

Created attachment 69612 [details, diff]
xscreensaver-4.22-nsfw-webcollage.patch

Could you test this (smaller) patch?

Comment 4 Tim Redman 2005-10-03 05:49:57 UTC

Seems to work fine so far.  Apologies for the overkill.  I was being overzealous
in my removal attempts.  I'll update if I notice anything.

Comment 5 Krzysztof Pawlik (RETIRED) gentoo-dev

2005-10-25 04:20:07 UTC

Fixed.