Summary: | Proposed patch to use ppp idle timer activity filter external to pppd | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alex <circuitsoft.alex> |
Component: | [OLD] Unspecified | Assignee: | Gentoo Dialup Developers <net-dialup> |
Status: | RESOLVED WONTFIX | ||
Severity: | enhancement | CC: | steev |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | The aformentioned patch |
Description
Alex
2005-08-16 16:32:44 UTC
Created attachment 66107 [details, diff]
The aformentioned patch
Did you already send it to the upstream ppp developers? Yes, but they have bugs quite old in their bug tracking system that are not yet dispatched/commented on. I thought Gentoo devs might tell me faster if this is a reasonable solution. patch looks simple and straight-forward. But nonetheless, since this is just a nice-to-have extra/new feature and not some kind of bug/security-fix, you should really wait for upstream to include it. the problem with these kind of patches is always, that the installation is gentoo-specific after and we have to support it till end of human life. hmm... I don't see the point. sure, you could reset idle timers through ALRM signal, but why use such a hairy solution? the only event needed is transmission/reception of some kind of packages, which already is handled by active-filters. I know, active-filters support has been buggy lately (libpcap devs really need to make up their mind), but I believe ppp-2.4.2-r15 and ppp-2.4.3-r8 really solve any related problem. I find active-filter ungodly confusing. Also, since this allows an iptables-based active filter, you can do far more complex active-filters. Example, Port Knocking. c'mon, who on Earth will use port knocking as active filter? a) why don't you test your filters using tcpdump before using them? b) if you really want a easier way of setting active filters, I recommend you to use diald. I've used in the good old days (when my link was a dialup one) with excellent results. a) Port-knocking is just an example. You could also use this to have any number of UIs ask the user before dialing. b) I've never found any decent documentation on diald. I've seen example config scripts, but never a thorough explanation of what each line does, etc. Anyway, upstream got back to me and said I ought to add hooks to ppp where necessary and implement the rest as a plugin. I have no idea how to do that, but it sounds like a good idea. |