Summary: | New ebuild: wxdockit-2.1 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Andreas Thillosen <corrosifdev> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | RESOLVED OBSOLETE | ||
Severity: | enhancement | CC: | wxwidgets |
Priority: | High | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
URL: | http://wxextended.sourceforge.net | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
wxdockit-2.1.ebuild
wxdockit-2.1.ebuild wxdockit-2.1.ebuild wxdockit-2.1.ebuild wxdockit-2.1.ebuild wxdockit-2.1.ebuild wxdockit-2.1.ebuild wxdockit-2.1.ebuild |
Description
Andreas Thillosen
2005-08-02 13:35:31 UTC
Created attachment 64952 [details]
wxdockit-2.1.ebuild
New ebuild for wxDockIt, a docking library for wxWidgets.
I suggest to put it in x11-libs.
Created attachment 65186 [details]
wxdockit-2.1.ebuild
Made a symbolic link for library name (libwxdockit-2.1.so->libwxdockit-2.1).
Created attachment 65216 [details]
wxdockit-2.1.ebuild
Corrected the license.
Please fix the following and reopen: * Your KEYWORDS look suspicious. See http://dev.gentoo.org/~plasmaroo/devmanual/keywording/#keywording-new-packages * You can kill src_unpack. * Why make and not emake in src_compile? If this is necessary, please include a comment in the ebuild. * ${D} should be quoted. * We don't usually dodoc license files. Created attachment 66776 [details]
wxdockit-2.1.ebuild
- Package was tested only on x86, so just leave one KEYWORD "~x86".
- useless src_unpack removed.
- emake instead of make in src_compile.
- removed dodoc license file.
Thanks for the tips...
By the way, what do you mean by "${D} should be quoted."?
In the official gentoo documentation, the recommended way to install is to
write:
make install DESTDIR=${D}
... by the way, I also added an unzip dependency. Created attachment 66780 [details]
wxdockit-2.1.ebuild
Added use of ${PV} in SRC_URI.
Created attachment 66785 [details]
wxdockit-2.1.ebuild
- Make use of ${MY_P} variable for more flexibility.
- Added SLOT="0".
Created attachment 66790 [details]
wxdockit-2.1.ebuild
In "die" case, talk about emake rather than make.
By ${D} being quoted, I mean use "${D}" rather than ${D}. Some of the docs and the tree don't do this, but it's a good habit to get into for new things. Created attachment 66804 [details]
wxdockit-2.1.ebuild
Use quotes with variables.
You forgot to reopen. Upstream seems very much dead, there hasn't been a new release since the aforementioned 2.1 in 2005. Moreover, I have had problems compiling that version on an amd64 system. Is there still any user demand for having this added to Portage? Needs wxGTK 2.6. |