| Summary: | Ebuild request: Atris - Alizarin Tetris | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jason Komar <jkomar> |
| Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
| Status: | CONFIRMED --- | ||
| Severity: | enhancement | Keywords: | EBUILD |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.cs.berkeley.edu/~weimer/atris/ | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Initial ebuild for Alizarin Tetris 1.0.7
Modified ebuild for Alizarin Tetris 1.0.7 Install patch fix for atris Makefile.am Install patch fix for atris-sounds Makefile.am Patch to clear pre-existing players data Patch to clear pre-existing scores data |
||
did you forget to attach the ebuild? Created attachment 64555 [details]
Initial ebuild for Alizarin Tetris 1.0.7
This is my first attempt at an ebuild, so any comments or tips/pointers on how
I could improve it would be appreciated. Thanks.
Nice first try.
Comments:
games should inherit the games eclass and call the games-specific funtions in
there (this sometimes exposes bugs in the upstream autotool foo, so be prepared
to fix/workaround those).
src_unpack isn't necessary, the default src_unpack will work for you.
use make DESTDIR="${D}" install ... instead of one of the einstall functions.
Those are deprecated.
Your two dodoc calls install some conflicting files. I recommend using docinto
for the sound stuff so it ends up in a subdir of the main doc files.
Call prepgamesdirs at the end of src_install like the other games ebuilds.
Created attachment 64649 [details]
Modified ebuild for Alizarin Tetris 1.0.7
Modified ebuild to inherit games eclass. Also some fixes to make it work with
the games eclass and with make DESTDIR="${D}" install ... instead of one of the
einstall functions.
Created attachment 64651 [details, diff]
Install patch fix for atris Makefile.am
Created attachment 64652 [details, diff]
Install patch fix for atris-sounds Makefile.am
Created attachment 64653 [details, diff]
Patch to clear pre-existing players data
Created attachment 64654 [details, diff]
Patch to clear pre-existing scores data
I sent the patches upstream to the authors. these fixes should also be submitted upstream ... This ebuild is working for me on multiple machines for both amd64 and x86. If someone else could try it out, it would be great to get it added to portage. We change the status on this end. Please don't change that. |
Alizarin Tetris is a Tetris-like game with a twist for Unix, Win32 and BeOS systems. It includes multi-player support, user-extensible color, shape and sound styles, can use TCP/IP networking and features a few different AI opponents. It was written using the SDL Library. Reproducible: Always Steps to Reproduce: 1.emerge atris Actual Results: emerge: there are no ebuilds to satisfy "atris". Expected Results: >>> games-puzzle/atris merged.