[patch] 66_all_binutils-2.17.50.0.2-warn-textrel.patch

66_all_binutils-2.17.50.0.2-warn-textrel.patch (text/plain), 2.06 KB, created by Gergan Penkov on 2006-06-17 09:03:12 UTC

textrels are bad for forcing copy-on-write (this affects everyone),
and for security/runtime code generation, this affects security ppl.
But in either case, it doesn't matter who needs textrels, it's
the very fact that they're needed at all.

2006-06-10  Ned Ludd  <[e-mail]>, Mike Frysinger <[e-mail]>

	* bfd/elflink.c (bfd_elf_final_link): Check all objects for TEXTRELs.
	* ld/ldmain.c (main): Change textrel warning default to true.
	* ld/testsuite/lib/ld-lib.exp (default_ld_simple_link): Scrub TEXTREL
	warnings from ld output.

--- bfd/elflink.c	2006-05-22 17:06:36.000000000 +0200
+++ bfd/elflink.c	2006-06-17 16:36:14.000000000 +0200
@@ -2809,6 +2809,10 @@
   hash_table = elf_hash_table (info);
   if (! is_elf_hash_table (hash_table))
     return FALSE;
+  //The shared objects will be checked later on
+  if (info->warn_shared_textrel && !info->shared && tag == DT_TEXTREL)
+    _bfd_error_handler
+      (_("warning: creating a DT_TEXTREL in object."));
 
   bed = get_elf_backend_data (hash_table->dynobj);
   s = bfd_get_section_by_name (hash_table->dynobj, ".dynamic");

--- ld/ldmain.c
+++ ld/ldmain.c
@@ -314,7 +314,7 @@ main (int argc, char **argv)
   link_info.flags = 0;
   link_info.flags_1 = 0;
   link_info.relax_pass = 1;
-  link_info.warn_shared_textrel = FALSE;
+  link_info.warn_shared_textrel = TRUE;
   link_info.gc_sections = FALSE;
 
   ldfile_add_arch ("");
--- ld/testsuite/lib/ld-lib.exp
+++ ld/testsuite/lib/ld-lib.exp
@@ -181,6 +181,11 @@ proc default_ld_simple_link { ld target 
     # symbol, since the default linker script might use ENTRY.
     regsub -all "(^|\n)(\[^\n\]*: warning: cannot find entry symbol\[^\n\]*\n?)" $exec_output "\\1" exec_output
 
+    # Gentoo tweak:
+    # We want to ignore TEXTREL warnings since we force enable them by default
+    regsub -all "^lt-ld-new: warning: creating a DT_TEXTREL in object\." $exec_output "\\1" exec_output
+    regsub -all "^lt-ld-new: warning: creating a DT_TEXTREL in a shared object\." $exec_output "\\1" exec_output
+
     if [string match "" $exec_output] then {
 	return 1
     } else {