[patch] rox.eclass.diff

rox.eclass.diff (text/plain), 3.04 KB, created by Daniel Black (RETIRED) on 2006-06-11 16:18:29 UTC

Index: rox.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/rox.eclass,v
retrieving revision 1.11
diff -u -b -B -r1.11 rox.eclass
--- rox.eclass	9 Dec 2005 21:16:46 -0000	1.11
+++ rox.eclass	11 Jun 2006 23:16:31 -0000
@@ -45,15 +45,15 @@
 
 
 rox_src_compile() {
-	cd ${APPNAME}
+	cd "${APPNAME}"
 	#Some packages need to be compiled.
 	chmod 755 ./AppRun
-	if [ -d "src/" ]; then
+	if [ -d src/ ]; then
 		./AppRun --compile || die "Failed to compile the package"
-		if [ -n ${KEEP_SRC} ]; then
-			( cd src
+		if [ -n "${KEEP_SRC}" ]; then
+			cd src
 			make clean
-			)
+			cd ..
 		else
 			rm -rf src
 		fi
@@ -63,8 +63,8 @@
 }
 
 rox_src_install() {
-	if [ -d ${APPNAME}/Help/ ]; then
-		for i in ${APPNAME}/Help/*; do
+	if [ -d "${APPNAME}/Help/" ]; then
+		for i in "${APPNAME}"/Help/*; do
 			dodoc "${i}"
 		done
 	fi
@@ -73,22 +73,22 @@
 
 	#set correct permissions on files, in case they are wrong
 	#include all subdirectories in search, just in case
-	find ${D}/usr/lib/rox/${APPNAME} -name 'AppRun' | xargs chmod 755 >/dev/null 2>&1
-	find ${D}/usr/lib/rox/${APPNAME} -name 'AppletRun' | xargs chmod 755 >/dev/null 2>&1
+	find "${D}/usr/lib/rox/${APPNAME}" -name 'AppRun' -print0 | xargs -0 chmod 755 >/dev/null 2>&1
+	find "${D}/usr/lib/rox/${APPNAME}" -name 'AppletRun' -print0 | xargs -0 chmod 755 >/dev/null 2>&1
 
 	# set permissions for programs where we have libdir script
-	if [ -f ${D}/usr/lib/rox/${APPNAME}/libdir ]; then
-		chmod 755 ${D}/usr/lib/rox/${APPNAME}/libdir
+	if [ -f "${D}/usr/lib/rox/${APPNAME}/libdir" ]; then
+		chmod 755 "${D}/usr/lib/rox/${APPNAME}/libdir"
 	fi
 
 	# set permissions for programs where we have rox_run script (all who using rox-clib )
-	if [ -f ${D}/usr/lib/rox/${APPNAME}/rox_run ]; then
-	    chmod 755 ${D}/usr/lib/rox/${APPNAME}/rox_run
+	if [ -f "${D}/usr/lib/rox/${APPNAME}/rox_run" ]; then
+	    chmod 755 "${D}/usr/lib/rox/${APPNAME}/rox_run"
 	fi
 
 	# some programs have choice_install script
-	if [ -f ${D}/usr/lib/rox/${APPNAME}/choice_install ]; then
-	    chmod 755 ${D}/usr/lib/rox/${APPNAME}/choice_install
+	if [ -f "${D}/usr/lib/rox/${APPNAME}/choice_install" ]; then
+	    chmod 755 "${D}/usr/lib/rox/${APPNAME}/choice_install"
 	fi
 
 	# set permissions on all binares files for compiled programs per arch
@@ -98,19 +98,19 @@
 		i?86) ARCH=ix86 ;;
 	    esac
 	    PLATFORM="`uname -s`-${ARCH}"
-	    chmod -R 755 ${D}/usr/lib/rox/${APPNAME}/${PLATFORM}
+	    chmod -R 755 "${D}/usr/lib/rox/${APPNAME}/${PLATFORM}"
 	fi
 
 	#create a script in bin to run the application from command line
 	dodir /usr/bin/
-	cat >${D}/usr/bin/${APPNAME} <<EOF
+	cat >"${D}/usr/bin/${APPNAME}" <<EOF
 #!/bin/sh
-exec /usr/lib/rox/${APPNAME}/AppRun "\$@"
+exec "/usr/lib/rox/${APPNAME}/AppRun" "\$@"
 EOF
-	chmod 755 ${D}/usr/bin/${APPNAME}
+	chmod 755 "${D}/usr/bin/${APPNAME}"
 
 	#now compile any and all python files
-	python_mod_optimize ${D}/usr/lib/rox/${APPNAME} >/dev/null 2>&1
+	python_mod_optimize "${D}/usr/lib/rox/${APPNAME}" >/dev/null 2>&1
 }
 
 rox_pkg_postinst() {