Attachment #848336 for bug #890624

View | Details | Raw Unified | Return to bug 890624
Collapse All | Expand All




*Rationale*: since license names do not contain dynamic parts (such as
package versions), using variables there has little advantage.  On the
other hand, variables reduce the usefulness of plain tools such as grep.


.. index:: d; variable

D must be used only in src_install and pkg_preinst
--------------------------------------------------
:PG: 0107
:Source: QA
:Reported: no

The ``D`` and ``ED`` variables must be used only in the ``src_install``
and ``pkg_preinst`` phase functions.  Exceptions to this policy can be
granted by the QA team.

*Rationale*: using ``D`` in other phases (e.g. ``src_configure``) is
error-prone and may lead to the path being embedded in files of the
installed image.  In addition, the directory pointed to by ``${D}``
does not exist in other phases.

Return to bug 890624

Lines 126-128 allowed. Link Here

(-)a/ebuild-format.rst (-1 / +18 lines)
126	Rationale: since license names do not contain dynamic parts (such as	126	Rationale: since license names do not contain dynamic parts (such as
127	package versions), using variables there has little advantage. On the	127	package versions), using variables there has little advantage. On the
128	other hand, variables reduce the usefulness of plain tools such as grep.	128	other hand, variables reduce the usefulness of plain tools such as grep.
129	-	129
		130
		131	.. index:: d; variable
		132
		133	D must be used only in src_install and pkg_preinst
		134	--------------------------------------------------
		135	:PG: 0107
		136	:Source: QA
		137	:Reported: no
		138
		139	The ``D`` and ``ED`` variables must be used only in the ``src_install``
		140	and ``pkg_preinst`` phase functions. Exceptions to this policy can be
		141	granted by the QA team.
		142
		143	Rationale: using ``D`` in other phases (e.g. ``src_configure``) is
		144	error-prone and may lead to the path being embedded in files of the
		145	installed image. In addition, the directory pointed to by ``${D}``
		146	does not exist in other phases.