Go to:
Gentoo Home
Documentation
Forums
Lists
Bugs
Planet
Store
Wiki
Get Gentoo!
Gentoo's Bugzilla – Attachment 833269 Details for
Bug 869404
sys-fs/lvm2-2.03.14-r3: fails to build with clang (lvmpolld-core.c:56:9: error: incompatible integer to pointer conversion returning 'int' from a function with result type 'const char *')
Home
|
New
–
[Ex]
|
Browse
|
Search
|
Privacy Policy
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
strerror_r-lvmpolld-core.patch
file_869404.txt (text/plain), 853 bytes, created by
Sam James
on 2022-11-18 02:32:37 UTC
(
hide
)
Description:
strerror_r-lvmpolld-core.patch
Filename:
MIME Type:
Creator:
Sam James
Created:
2022-11-18 02:32:37 UTC
Size:
853 bytes
patch
obsolete
>We can't assume that strerror_r returns char* just because _GNU_SOURCE is defined. We already call the appropriate autoconf test, so let's use its result >(STRERROR_R_CHAR_P). > >Note that in configure, _GNU_SOURCE is always set, but we add a defined guard just in case for futureproofing. > >Bug: https://bugs.gentoo.org/869404 >--- a/daemons/lvmpolld/lvmpolld-core.c >+++ b/daemons/lvmpolld/lvmpolld-core.c >@@ -52,7 +52,7 @@ static pthread_key_t key; > > static const char *_strerror_r(int errnum, struct lvmpolld_thread_data *data) > { >-#ifdef _GNU_SOURCE >+#if defined(_GNU_SOURCE) && defined(STRERROR_R_CHAR_P) > return strerror_r(errnum, data->buf, sizeof(data->buf)); /* never returns NULL */ > #elif (_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) > return strerror_r(errnum, data->buf, sizeof(data->buf)) ? "" : data->buf;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 869404
:
804328
| 833269