From b30cfbb5dd7bf0a03730a5e25d35b4fd61add6e7 Mon Sep 17 00:00:00 2001 From: Matt Borland Date: Sat, 28 May 2022 08:53:35 -0700 Subject: [PATCH 1/2] Fix for issue #464 --- boost/multiprecision/cpp_dec_float.hpp | 22 +++++++++++-- libs/multiprecision/test/Jamfile.v2 | 1 + libs/multiprecision/test/git_issue_464.cpp | 31 +++++++++++++++++++ 3 files changed, 52 insertions(+), 2 deletions(-) create mode 100644 test/git_issue_464.cpp diff --git a/boost/multiprecision/cpp_dec_float.hpp b/boost/multiprecision/cpp_dec_float.hpp index bed38d5cf..074073827 100644 --- a/boost/multiprecision/cpp_dec_float.hpp +++ b/boost/multiprecision/cpp_dec_float.hpp @@ -26,6 +26,8 @@ #include #include #include +#include +#include #include #include #include @@ -1603,7 +1605,15 @@ double cpp_dec_float::extract_double() const : -std::numeric_limits::infinity()); } - return std::strtod(str(std::numeric_limits::digits10 + (2 + 1), std::ios_base::scientific).c_str(), nullptr); + std::stringstream ss; + ss.imbue(std::locale::classic()); + + ss << str(std::numeric_limits::digits10 + (2 + 1), std::ios_base::scientific); + + double d; + ss >> d; + + return d; } template @@ -1642,7 +1652,15 @@ long double cpp_dec_float::extract_long_doubl : -std::numeric_limits::infinity()); } - return std::strtold(str(std::numeric_limits::digits10 + (2 + 1), std::ios_base::scientific).c_str(), nullptr); + std::stringstream ss; + ss.imbue(std::locale::classic()); + + ss << str(std::numeric_limits::digits10 + (2 + 1), std::ios_base::scientific); + + long double ld; + ss >> ld; + + return ld; } template diff --git a/libs/multiprecision/test/Jamfile.v2 b/libs/multiprecision/test/Jamfile.v2 index 4ad012273..f5d88edf2 100644 --- a/libs/multiprecision/test/Jamfile.v2 +++ b/libs/multiprecision/test/Jamfile.v2 @@ -1176,6 +1176,7 @@ test-suite misc : [ run git_issue_426.cpp : : : [ check-target-builds ../config//has_mpfr : gmp mpfr TEST_MPFR ] [ check-target-builds ../config//has_float128 : quadmath TEST_FLOAT128 ] ] [ run git_issue_277.cpp ] [ run git_issue_313.cpp ] + [ run git_issue_464.cpp ] [ compile git_issue_98.cpp : [ check-target-builds ../config//has_float128 : TEST_FLOAT128 quadmath : ] [ check-target-builds ../config//has_gmp : TEST_GMP gmp : ] diff --git a/libs/multiprecision/test/git_issue_464.cpp b/libs/multiprecision/test/git_issue_464.cpp new file mode 100644 index 000000000..dc9d0054a --- /dev/null +++ b/libs/multiprecision/test/git_issue_464.cpp @@ -0,0 +1,31 @@ +/////////////////////////////////////////////////////////////////////////////// +// Copyright 2022 Matt Borland. Distributed under the Boost +// Software License, Version 1.0. (See accompanying file +// LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt) +// +// See: https://github.com/boostorg/multiprecision/issues/464 + +#include +#include +#include "test.hpp" + +template +void test() +{ + auto a = boost::multiprecision::cpp_dec_float_50 {12345}; + + auto d1 = a.convert_to(); + + std::locale::global(std::locale("de_DE")); + auto d2 = a.convert_to(); + + BOOST_CHECK_EQUAL(d1, d2); +} + +int main(void) +{ + test(); + test(); + + return boost::report_errors(); +} From 2a2cb9387505acf76ed0cdce9e79725f6a3296a9 Mon Sep 17 00:00:00 2001 From: Matt Borland Date: Sat, 28 May 2022 16:47:39 -0700 Subject: [PATCH 2/2] Remove from CI run and add missing header --- include/boost/multiprecision/cpp_dec_float.hpp | 1 + test/Jamfile.v2 | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/boost/multiprecision/cpp_dec_float.hpp b/boost/multiprecision/cpp_dec_float.hpp index 074073827..2810aaf44 100644 --- a/boost/multiprecision/cpp_dec_float.hpp +++ b/boost/multiprecision/cpp_dec_float.hpp @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include diff --git a/libs/multiprecision/test/Jamfile.v2 b/libs/multiprecision/test/Jamfile.v2 index f5d88edf2..4ad012273 100644 --- a/libs/multiprecision/test/Jamfile.v2 +++ b/libs/multiprecision/test/Jamfile.v2 @@ -1176,7 +1176,6 @@ test-suite misc : [ run git_issue_426.cpp : : : [ check-target-builds ../config//has_mpfr : gmp mpfr TEST_MPFR ] [ check-target-builds ../config//has_float128 : quadmath TEST_FLOAT128 ] ] [ run git_issue_277.cpp ] [ run git_issue_313.cpp ] - [ run git_issue_464.cpp ] [ compile git_issue_98.cpp : [ check-target-builds ../config//has_float128 : TEST_FLOAT128 quadmath : ] [ check-target-builds ../config//has_gmp : TEST_GMP gmp : ]