[patch] fix garbage in man's messages

man-1.6a-messages.patch (text/plain), 4.32 KB, created by Evgeniy Dushistov on 2005-12-30 13:18:27 UTC

diff -rud man-1.6a/src/gripes.c man-1.6a.new/src/gripes.c
--- man-1.6a/src/gripes.c	2005-08-20 23:26:06.000000000 +0000
+++ man-1.6a.new/src/gripes.c	2005-09-19 23:12:34.000000000 +0000
@@ -4,6 +4,7 @@
 
 #include "gripes.h"
 #include "man.h"		/* for progname */
+#include "man-iconv.h" /*for get_locale_charset */
 
 extern char *msg[];
 
@@ -113,27 +114,60 @@
 			"man: internal error - cannot find message %d\n", n);
 		exit (1);
         }
+
 	return s;
 }
 
 #endif /* NONLS */
 
 void
-gripe (int n, ...) {
+gripe (int n, ...) {	
     va_list p;
+    char *mes;
+    char *conv_mes;
+    int free_mes;
 
     va_start(p, n);
-    vfprintf (stderr, getmsg(n), p);
+    mes=getmsg(n);
+#ifdef USE_ICONV	
+    free_mes=1;
+    if ((conv_mes=convert_with_iconv(mes, "UTF-8", 
+				     get_locale_charset()))==NULL) {
+#endif			
+	    conv_mes=mes;
+	    free_mes=0;
+#ifdef USE_ICONV		
+    }
+#endif
+    vfprintf (stderr, conv_mes, p);
     va_end(p);
     fflush (stderr);
+    if (free_mes)
+	    free(conv_mes);
 }
 
 void
 fatal (int n, ...) {
     va_list p;
+    char *mes, *conv_mes;
+    int free_mes;
+
     fprintf (stderr, "%s: ", progname);
     va_start(p, n);
-    vfprintf (stderr, getmsg(n), p);
+    mes=getmsg(n);
+#ifdef USE_ICONV	
+    free_mes=1;
+    if ((conv_mes=convert_with_iconv(mes, "UTF-8", 
+				     get_locale_charset()))==NULL) {
+#endif			
+	    conv_mes=mes;
+	    free_mes=0;
+#ifdef USE_ICONV		
+    }
+#endif
+    vfprintf (stderr, conv_mes, p);
     va_end(p);
+    if (free_mes)
+	    free(conv_mes);
     exit (1);
 }
diff -rud man-1.6a/src/Makefile.in man-1.6a.new/src/Makefile.in
--- man-1.6a/src/Makefile.in	2005-08-20 23:26:06.000000000 +0000
+++ man-1.6a.new/src/Makefile.in	2005-09-19 23:08:41.000000000 +0000
@@ -17,7 +17,7 @@
 
 pager = @pager@
 
-DEFS = @DEFS@
+DEFS = @DEFS@ -DUSE_ICONV
 CWARN = -Wall -Wstrict-prototypes -Wmissing-prototypes
 CWARNNP = -Wall
 
ôÏÌØËÏ × man-1.6a.new/src: man.conf
diff -rud man-1.6a/src/man-iconv.c man-1.6a.new/src/man-iconv.c
--- man-1.6a/src/man-iconv.c	2005-08-20 23:26:06.000000000 +0000
+++ man-1.6a.new/src/man-iconv.c	2005-09-19 23:04:55.000000000 +0000
@@ -20,7 +20,6 @@
  * By default iconv is not used - this is the wrong interface.
  * But if you want it, define USE_ICONV.
  */
-#undef USE_ICONV
 
 #include <stdio.h>	/* NULL */
 
@@ -31,6 +30,7 @@
 #include <locale.h>	/* setlocale */
 #include <langinfo.h>	/* nl_langinfo */
 #include <iconv.h>	/* iconv_open */
+#include <errno.h>      /* errno variable */
 #include "man-iconv.h"	/* get_converter */
 #include "util.h"	/* my_strdup */
 #include "man.h"	/* debug */
@@ -65,7 +65,7 @@
 	return iconv_flags;
 }
 
-static char *
+char *
 get_locale_charset (void) {
 	char *old_lc_ctype, *charset;
 
@@ -77,6 +77,49 @@
 	return charset;
 }
 
+char *
+convert_with_iconv (const char *from, const char *from_codeset, 
+		    const char *to_codest) {
+	size_t inbytes_remaining;
+	size_t outbytes_remaining;
+	size_t outbuf_size;
+	char *dest, *outp;
+	size_t len;
+	const char *p;
+	iconv_t cd;
+	size_t err;
+	p=from;
+	if ((cd=iconv_open(to_codest, from_codeset))==(iconv_t)(-1))
+		return NULL;
+	len=strlen(from);
+	inbytes_remaining = len;
+	outbuf_size = len + 1; /* + 1 for nul in case len == 1 */
+	outbytes_remaining = outbuf_size - 1; /* -1 for nul */
+	dest=outp=malloc(outbuf_size);
+ again:
+	err = iconv (cd, (char **)&p, &inbytes_remaining, &outp, &outbytes_remaining);
+	if (err == (size_t) -1) {
+		if (errno==E2BIG) {			
+			size_t used = outp - dest;
+
+			outbuf_size *= 2;
+			dest = realloc (dest, outbuf_size);
+		
+			outp = dest + used;
+			outbytes_remaining = outbuf_size - used - 1; /* -1 for nul */
+
+			goto again;
+		} else {
+			free(dest);
+			dest=NULL;
+			goto exit;
+		}
+	}
+ exit:
+	iconv_close(cd);
+	return dest;
+}
+
 static char * 
 get_man_charset (const char *path) {
 	char *charset_env, *file, *path2, *p;
diff -rud man-1.6a/src/man-iconv.h man-1.6a.new/src/man-iconv.h
--- man-1.6a/src/man-iconv.h	2005-08-20 23:26:06.000000000 +0000
+++ man-1.6a.new/src/man-iconv.h	2005-09-19 23:10:23.000000000 +0000
@@ -1 +1,13 @@
+#ifndef MAN_ICONV_H
+#define MAN_ICONV_H
+
 extern const char *get_converter (const char *path);
+
+#ifdef USE_ICONV
+extern char *get_locale_charset (void);
+extern char *convert_with_iconv (const char *from, 
+				 const char *from_codeset, 
+				 const char *to_codest);
+#endif
+
+#endif/*MAN_ICONV_H*/