[patch] eend: Output QA notice when called without argument

0001-eend-Output-QA-notice-when-called-without-argument.patch (text/plain), 938 bytes, created by Ulrich Müller on 2021-09-03 16:08:48 UTC

From 030eaacf1f674819d60c8c4465b3ed26495df052 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <[e-mail]>
Date: Fri, 3 Sep 2021 18:03:27 +0200
Subject: [PATCH] eend: Output QA notice when called without argument
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PMS says about eend: "Takes one fixed argument, which is a numeric
return code, and an optional message in all subsequent arguments."

Bug: https://bugs.gentoo.org/703520
Signed-off-by: Ulrich Müller <[e-mail]>
---
 bin/isolated-functions.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
index b495ae6c7..5b1f372d2 100644
--- a/bin/isolated-functions.sh
+++ b/bin/isolated-functions.sh
@@ -364,6 +364,7 @@ __eend() {
 }
 
 eend() {
+	[[ -n $1 ]] || eqawarn "QA Notice: eend called without return code"
 	local retval=${1:-0}
 	shift
 
-- 
2.33.0