[patch] Patch to fix hangs when saving selection as JPEGs

avidemux_jpegs.patch (text/plain), 1.36 KB, created by Alexey Dobriyan on 2005-09-03 02:50:39 UTC

[PATCH] avidemux: fix horrors when saving selection as JPEGs

Steps to reproduce:
1. File->Open Video...
2. File->Save->Save Images->Save Selection as JPEGs...
3. Say something
4. Hit OK

With some luck (read: don't touch mouse, reproduce with keyboard only,
2.0.42) you'll have:
---------------------------------------------------------------------------
avidemux2: ADM_memsupport.cpp:89: void ADM_dezalloc(void*): Assertion `0' failed.
Aborted
---------------------------------------------------------------------------
But all JPEGs will be correctly saved.

In the worst (read: reproduce with mouse) avidemux2 will eat 99% cpu
and not react to anything (IIRC with 2.0.24).

Somewhere in the middle are non-descriptive gtk backtraces and then
lockup.

wtf is going on? you ask. The answer is surprisingly simple. Look at
avidemux/gtk_gui.cpp, lines 1313, 1330, 1331 and 1368. Especially, at
lines 1330 and 1368.

avidemux/gtk_gui.cpp:
  1313    ADMImage *src=NULL;

  1330          //src=new uint8_t [sz];
  1331          src=new ADMImage(avifileinfo->width,avifileinfo->height);

How do you think "src" is still freed?

--- avidemux-2.0.42/avidemux/gtk_gui.cpp
+++ avidemux-2.0.42-jpegs/avidemux/gtk_gui.cpp
@@ -1365,7 +1365,7 @@ void A_saveBunchJpg(char *name)
 	GUI_Alert ("Done.");
 _bunch_abort:	
     	delete [] buffer;
-	delete [] src;
+	delete src;
 	delete codec;
 	return ;