[patch] 0001-powerpc-use-C-implementation-of-memset-in-rtld-BZ-26.patch

0001-powerpc-use-C-implementation-of-memset-in-rtld-BZ-26.patch (text/plain), 2.56 KB, created by Sergei Trofimovich (RETIRED) on 2020-08-22 14:14:21 UTC

From 1587ea7d57226bb80a17618a9ac9f767e6857a7f Mon Sep 17 00:00:00 2001
From: Sergei Trofimovich <[e-mail]>
Date: Sat, 22 Aug 2020 15:01:00 +0100
Subject: [PATCH] powerpc: use C implementation of memset in rtld [BZ #26522]

Before the change rtld-memset used power4 assembly implementation
which assumes 128-byte cache block size (size of block 'dcbz'
zeroes out). On machines with smaller block size this implementation
silently leaves chunks of memory uninitialized.

The change switches to C implementation (similar to what
non-multiarch powerpc variant does).

Signed-off-by: Sergei Trofimovich <[e-mail]>
---
 .../powerpc32/power4/multiarch/rtld-memset.S   | 18 ------------------
 .../powerpc32/power4/multiarch/rtld-memset.c   |  4 ++++
 2 files changed, 4 insertions(+), 18 deletions(-)
 delete mode 100644 sysdeps/powerpc/powerpc32/power4/multiarch/rtld-memset.S
 create mode 100644 sysdeps/powerpc/powerpc32/power4/multiarch/rtld-memset.c

diff --git a/sysdeps/powerpc/powerpc32/power4/multiarch/rtld-memset.S b/sysdeps/powerpc/powerpc32/power4/multiarch/rtld-memset.S
deleted file mode 100644
index 2295e292b9..0000000000
--- a/sysdeps/powerpc/powerpc32/power4/multiarch/rtld-memset.S
+++ /dev/null
@@ -1,18 +0,0 @@
-/* Copyright (C) 2013-2020 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <https://www.gnu.org/licenses/>.  */
-
-#include <sysdeps/powerpc/powerpc32/power4/memset.S>
diff --git a/sysdeps/powerpc/powerpc32/power4/multiarch/rtld-memset.c b/sysdeps/powerpc/powerpc32/power4/multiarch/rtld-memset.c
new file mode 100644
index 0000000000..f3ed8ad1e7
--- /dev/null
+++ b/sysdeps/powerpc/powerpc32/power4/multiarch/rtld-memset.c
@@ -0,0 +1,4 @@
+/* PPCA2 has a different cache-line size than the usual 128 bytes.  To avoid
+   using code that assumes cache-line size to be 128 bytes (with dcbz
+   instructions) we use the generic code instead.  */
+#include <string/memset.c>
-- 
2.28.0