Go to:
Gentoo Home
Documentation
Forums
Lists
Bugs
Planet
Store
Wiki
Get Gentoo!
Gentoo's Bugzilla – Attachment 6549 Details for
Bug 12208
segfault in cdcd due to bug in libcdaudio 0.99.6
Home
|
New
–
[Ex]
|
Browse
|
Search
|
Privacy Policy
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Fixes wrong fprintf() call, plus some error checks.
libcdaudio-0.99.6-fprintf+errorret.patch (text/plain), 987 bytes, created by
Sam Yates
on 2002-12-16 16:33:51 UTC
(
hide
)
Description:
Fixes wrong fprintf() call, plus some error checks.
Filename:
MIME Type:
Creator:
Sam Yates
Created:
2002-12-16 16:33:51 UTC
Size:
987 bytes
patch
obsolete
>--- libcdaudio-0.99.6/source/cddb.c.orig 2002-12-16 23:18:40.000000000 +0100 >+++ libcdaudio-0.99.6/source/cddb.c 2002-12-16 23:20:38.000000000 +0100 >@@ -840,7 +840,7 @@ > inbuffer[index] = inchar; > } > >- fprintf(stdout, "%*s\n", index, index, inbuffer); >+ fprintf(stdout, "%*s\n", index, inbuffer); > return index; > } > >@@ -916,7 +916,7 @@ > free(outbuffer); > > if(mode == CDDB_MODE_HTTP) >- cddb_skip_http_header(sock); >+ if (cddb_skip_http_header(sock)<0) return -1; > > if((inbuffer = malloc(256)) == NULL) > return -1; >@@ -1160,11 +1160,15 @@ > cddb_genre(entry->entry_genre), > entry->entry_id); > >- send(sock, outbuffer, strlen(outbuffer), 0); >+ if(send(sock, outbuffer, strlen(outbuffer), 0)<0) { >+ free(outbuffer); >+ return -1; >+ } >+ > free(outbuffer); > > if(mode == CDDB_MODE_HTTP) >- cddb_skip_http_header(sock); >+ if (cddb_skip_http_header(sock)<0) return -1; > > if(cddb_read_token(sock, token) < 0) > return -1;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 12208
: 6549