Attachment 600138 Details for Bug 702508 – 0004-ebuild-writing-users-and-groups-use-non-fictional-ex.patch

[patch] 0004-ebuild-writing-users-and-groups-use-non-fictional-ex.patch

0004-ebuild-writing-users-and-groups-use-non-fictional-ex.patch (text/plain), 2.49 KB, created by Michael Orlitzky on 2019-12-19 13:54:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Orlitzky

Created: 2019-12-19 13:54:45 UTC

Size: 2.49 KB

patch

obsolete

>From a349734234a43f575f793ad4f4898bc2fcd402b8 Mon Sep 17 00:00:00 2001
>From: Michael Orlitzky <mjo@gentoo.org>
>Date: Thu, 19 Dec 2019 08:44:35 -0500
>Subject: [PATCH 4/4] ebuild-writing/users-and-groups: use non-fictional
> example ebuilds.
>
>Instead of specifying invalid UID/GIDs in our example user/group
>ebuilds, let's just use a good example from the tree. The
>acct-user/group ebuilds for suricata closely match the examples
>already given, but with the added benefit of being real examples.
>
>Since we (and the ebuilds themselves) state that they're for suricata,
>it should be clear to the reader that the variables need to be
>updated. And the fact that the IDs dwell in the high-4xx range
>reflects the fact that we're generally counting down from there.
>
>Signed-off-by: Michael Orlitzky <mjo@gentoo.org>
>Closes: https://bugs.gentoo.org/702508
>---
> ebuild-writing/users-and-groups/text.xml | 22 ++++++++++++----------
> 1 file changed, 12 insertions(+), 10 deletions(-)
>
>diff --git a/ebuild-writing/users-and-groups/text.xml b/ebuild-writing/users-and-groups/text.xml
>index a11f549..0ac8fda 100644
>--- a/ebuild-writing/users-and-groups/text.xml
>+++ b/ebuild-writing/users-and-groups/text.xml
>@@ -34,9 +34,10 @@ and must not be used for new packages.
> <body>
> 
> 
>-Group ebuilds are placed in <c>acct-group</c> category, with the package name
>-matching the group name. The following can be used as a template for writing
>-group ebuilds:
>+Group ebuilds are placed in <c>acct-group</c> category, with the
>+package name matching the group name. The following ebuild for
>+<c>acct-group/suricata</c> can be used as a template for writing group
>+ebuilds:
> 
> 
> <pre>
>@@ -47,8 +48,8 @@ EAPI=7
> 
> inherit acct-group
> 
>-DESCRIPTION="Meaningful description of the group"
>-ACCT_GROUP_ID=123456
>+DESCRIPTION="Group for Suricata IDS"
>+ACCT_GROUP_ID=477
> </pre>
> 
> 
>@@ -63,9 +64,10 @@ ACCT_GROUP_ID=123456
> <body>
> 
> 
>-User ebuilds are placed in <c>acct-user</c> category, with the package name
>-matching the user name. The following can be used as a template for writing
>-user ebuilds:
>+User ebuilds are placed in <c>acct-user</c> category, with the package
>+name matching the user name. The following ebuild for
>+<c>acct-user/suricata</c> can be used as a template for writing user
>+ebuilds:
> 
> 
> <pre>
>@@ -76,8 +78,8 @@ EAPI=7
> 
> inherit acct-user
> 
>-DESCRIPTION="Meaningful description of the user"
>-ACCT_USER_ID=123456
>+DESCRIPTION="User for Suricata IDS"
>+ACCT_USER_ID=477
> ACCT_USER_GROUPS=( "${PN}" )
> 
> acct-user_add_deps
>-- 
>2.24.1
>

Actions: View | Diff

Attachments on bug 702508: 599110 | 599112 | 599114 | 600136 | 600138