From 9f68391f9615d29651ccd53ec2cc9ab3827fa877 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= Date: Mon, 12 Aug 2019 22:58:17 +0200 Subject: [PATCH] econf: Unconditionally die on error in EAPIs 0 to 3. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As specified by PMS: "econf [...] Should any portion of it fail, it must abort the build using die, unless run using nonfatal, in which case it must return non-zero exit status." https://projects.gentoo.org/pms/7/pms.html#x1-12800012.3.8 Bug: https://bugs.gentoo.org/692024 Signed-off-by: Ulrich Müller --- bin/phase-helpers.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh index 15fe8c682..5f0e202c2 100644 --- a/bin/phase-helpers.sh +++ b/bin/phase-helpers.sh @@ -676,6 +676,8 @@ econf() { echo "!!! Please attach the following file when seeking support:" echo "!!! ${PWD}/config.log" fi + # econf dies unconditionally in EAPIs 0 to 3 + ___eapi_helpers_can_die || die "econf failed" __helpers_die "econf failed" return 1 fi -- 2.22.0