Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
View | Details | Raw Unified | Return to bug 676734
Collapse All | Expand All

(-)a/libnetclient/net-client-pop.c_org (-3 / +10 lines)
Lines 722-727 Link Here
722
	client->priv->can_pipelining = FALSE;
722
	client->priv->can_pipelining = FALSE;
723
	result = net_client_pop_execute(client, "CAPA", NULL, NULL);
723
	result = net_client_pop_execute(client, "CAPA", NULL, NULL);
724
724
725
	/* qmail resopnds -ERR Authorizaion First, so the while is never executed */ 
725
	/* evaluate the response */
726
	/* evaluate the response */
726
	done = FALSE;
727
	done = FALSE;
727
	while (result && !done) {
728
	while (result && !done) {
Lines 770-778 Link Here
770
771
771
	/* see RFC 1939, Sect. 4: if no other authentication method is supported explicitly (in particular no APOP), the server *must*
772
	/* see RFC 1939, Sect. 4: if no other authentication method is supported explicitly (in particular no APOP), the server *must*
772
	 * at least support USER/PASS... */
773
	 * at least support USER/PASS... */
773
	if (*auth_supported == 0U) {
774
774
		*auth_supported = NET_CLIENT_POP_AUTH_USER_PASS;
775
	/* if (*auth_supported == 0U) has to be wrong, we set *auth_supported = *auth_supported & NET_CLIENT_POP_AUTH_APOP; above 
775
	}
776
	   drop the if altogether, since NET_CLIENT_POP_AUTH_USER_PASS is way down the list of preferences, so won't be used 
777
	   if we have something better. 
778
	   fixes POP3 and POP3S authorization with qmail*/ 
779
780
	/* if (*auth_supported == NET_CLIENT_POP_AUTH_APOP) { */
781
	*auth_supported |= NET_CLIENT_POP_AUTH_USER_PASS;
782
	/* } */
776
	client->priv->can_pipelining = TRUE;
783
	client->priv->can_pipelining = TRUE;
777
}
784
}
778
785

Return to bug 676734