Go to:
Gentoo Home
Documentation
Forums
Lists
Bugs
Planet
Store
Wiki
Get Gentoo!
Gentoo's Bugzilla – Attachment 552096 Details for
Bug 669034
www-client/chromium-70.0.3538.67 with media-libs/harfbuzz-2.0.0 - error: no matching function for call to 'hb_font_funcs_set_glyph_h_advances_func'
Home
|
New
–
[Ex]
|
Browse
|
Search
|
Privacy Policy
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Fix harfbuzz 2.0 build failure
chromium-harfbuzz-r0.patch (text/plain), 4.08 KB, created by
Mike Gilbert
on 2018-10-21 14:17:16 UTC
(
hide
)
Description:
Fix harfbuzz 2.0 build failure
Filename:
MIME Type:
Creator:
Mike Gilbert
Created:
2018-10-21 14:17:16 UTC
Size:
4.08 KB
patch
obsolete
>From 7ae38170a117e909bb28e1470842b68de3501197 Mon Sep 17 00:00:00 2001 >From: Mike Gilbert <floppymaster@gmail.com> >Date: Sun, 21 Oct 2018 10:06:53 -0400 >Subject: [PATCH] blink: add 'const' modifier for harfbuzz hb_codepoint_t > pointers > >This resolves a build failure against harfbuzz 2.0. > >Based on a patch by Alexandre Fierreira. > >Bug: https://bugs.gentoo.org/669034 >--- > .../renderer/platform/fonts/shaping/harfbuzz_face.cc | 2 +- > .../renderer/platform/fonts/skia/skia_text_metrics.cc | 9 +++++++-- > .../renderer/platform/fonts/skia/skia_text_metrics.h | 2 +- > 3 files changed, 9 insertions(+), 4 deletions(-) > >diff --git a/third_party/blink/renderer/platform/fonts/shaping/harfbuzz_face.cc b/third_party/blink/renderer/platform/fonts/shaping/harfbuzz_face.cc >index 8e7d91ca371f..e279a5876cb3 100644 >--- a/third_party/blink/renderer/platform/fonts/shaping/harfbuzz_face.cc >+++ b/third_party/blink/renderer/platform/fonts/shaping/harfbuzz_face.cc >@@ -139,7 +139,7 @@ static hb_position_t HarfBuzzGetGlyphHorizontalAdvance(hb_font_t* hb_font, > static void HarfBuzzGetGlyphHorizontalAdvances(hb_font_t* font, > void* font_data, > unsigned count, >- hb_codepoint_t* first_glyph, >+ const hb_codepoint_t* first_glyph, > unsigned int glyph_stride, > hb_position_t* first_advance, > unsigned int advance_stride, >diff --git a/third_party/blink/renderer/platform/fonts/skia/skia_text_metrics.cc b/third_party/blink/renderer/platform/fonts/skia/skia_text_metrics.cc >index 77ec6209fab9..9f9070921448 100644 >--- a/third_party/blink/renderer/platform/fonts/skia/skia_text_metrics.cc >+++ b/third_party/blink/renderer/platform/fonts/skia/skia_text_metrics.cc >@@ -18,6 +18,11 @@ T* advance_by_byte_size(T* p, unsigned byte_size) { > return reinterpret_cast<T*>(reinterpret_cast<uint8_t*>(p) + byte_size); > } > >+template <class T> >+T* advance_by_byte_size_const(T* p, unsigned byte_size) { >+ return reinterpret_cast<T*>(reinterpret_cast<const uint8_t*>(p) + byte_size); >+} >+ > } // namespace > > SkiaTextMetrics::SkiaTextMetrics(const SkPaint* paint) : paint_(paint) { >@@ -39,7 +44,7 @@ void SkiaTextMetrics::GetGlyphWidthForHarfBuzz(hb_codepoint_t codepoint, > } > > void SkiaTextMetrics::GetGlyphWidthForHarfBuzz(unsigned count, >- hb_codepoint_t* glyphs, >+ const hb_codepoint_t* glyphs, > unsigned glyph_stride, > hb_position_t* advances, > unsigned advance_stride) { >@@ -48,7 +53,7 @@ void SkiaTextMetrics::GetGlyphWidthForHarfBuzz(unsigned count, > // array that copy them to a regular array. > Vector<Glyph, 256> glyph_array(count); > for (unsigned i = 0; i < count; >- i++, glyphs = advance_by_byte_size(glyphs, glyph_stride)) { >+ i++, glyphs = advance_by_byte_size_const(glyphs, glyph_stride)) { > glyph_array[i] = *glyphs; > } > Vector<SkScalar, 256> sk_width_array(count); >diff --git a/third_party/blink/renderer/platform/fonts/skia/skia_text_metrics.h b/third_party/blink/renderer/platform/fonts/skia/skia_text_metrics.h >index 787d8af0375a..3bc4407c641b 100644 >--- a/third_party/blink/renderer/platform/fonts/skia/skia_text_metrics.h >+++ b/third_party/blink/renderer/platform/fonts/skia/skia_text_metrics.h >@@ -19,7 +19,7 @@ class SkiaTextMetrics final { > > void GetGlyphWidthForHarfBuzz(hb_codepoint_t, hb_position_t* width); > void GetGlyphWidthForHarfBuzz(unsigned count, >- hb_codepoint_t* first_glyph, >+ const hb_codepoint_t* first_glyph, > unsigned glyph_stride, > hb_position_t* first_advance, > unsigned advance_stride); >-- >2.19.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 669034
:
552026
|
552028
| 552096