From rpluim@gmail.com Thu Oct 11 14:06:47 2018 Return-Path: Delivered-To: tjernlund@tjernlund.se Received: from mx2.pub.mailpod1-cph3.one.com ([10.27.24.12]) by mailstorage27.cst.mailpod1-cph3.one.com with LMTP id eJ90APdYv1tYXQAAMwKpMA for ; Thu, 11 Oct 2018 14:06:47 +0000 X-HalOne-ID: e330aab7-cd5e-11e8-bb08-248a07b43572 Received: from mail-wr1-f48.google.com (unknown [209.85.221.48]) by mx2.pub.mailpod1-cph3.one.com (Halon) with ESMTPS id e330aab7-cd5e-11e8-bb08-248a07b43572; Thu, 11 Oct 2018 14:06:45 +0000 (UTC) Received: by mail-wr1-f48.google.com with SMTP id w5-v6so9863231wrt.2 for ; Thu, 11 Oct 2018 07:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=Kf7Nh4KjXs7kMQ1pHfEk5ylaF/FlKwMEeXYcK0i5UB0=; b=YAb0j0aXVyasLvk/03k8r7lH52BcvkptygaSxcna7x3w+5NecEz2dI7E013k/7FE5Z chpO1uZa977ZCVEuHbeBoVLEsj1itkZIpPsbcS2Xi3Rrq8GjUtXN0po6R23F+v2A+KqZ 76AFnSG5kzcxU6TU1+1+8FsBi7ybhJiYfo+yTsFHqkKvjTMDtFOn4/r+Cr6A+hnz/+ye OaaOSLexCeEtfgXWGSK2Hb6kSFz8t/kGlf1MT+lz/JM8z4j/ioRywgYF32I59o5XkAPE 6fHZf/djTzdhT6yC9RTQAF+R860uydB02xFVsSQK4/2ePIQI+qMDNJCAJxlb5DomiC5P 5CnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=Kf7Nh4KjXs7kMQ1pHfEk5ylaF/FlKwMEeXYcK0i5UB0=; b=BWDAwppJnkFukmySLPh4jrv4+BE0TYXU9z4YYPZZftOY00AlVpRI5GXYxu3qZpfwXV 7U1UQscoY/Ce0hyenQAVLHOJYy7oJk3nPRn8PZOh3HdITK+FSeIXAIIFgNmpx75sFcII XanX2ee5S11+4/SzlR+6dxm7DXzibItni6jZbg2wAD9PKIbspQf8iXOTKpI39/gzrWCp dBrUefNsNNHhmr4MWnj6xI1UpgY57D+UusCB4oSh94+7KLscaE+lyCePyKXHlSjXUifx xpwKlpEYOWIBVoG9tKxUGJGvMrbGF0xttf6N2KPlM+4cF/fwkBxM4lRIdBMXFaBpoOdw wkFA== X-Gm-Message-State: ABuFfoiFQmfrtcbpnZDRg/hNMhFNKhyMQ2/1AQFgPedZpNjdc6SULtjk +BfPHkj2wBcWJcuieFdVncE= X-Google-Smtp-Source: ACcGV61C1CF7mOLAgBMtF8KpsnMP/XGtwJy6cddiIP5Peplyo/R+DDuMb8YxqpYjQgG9ZSWcKEjAFA== X-Received: by 2002:a5d:4449:: with SMTP id x9-v6mr1686544wrr.306.1539266805025; Thu, 11 Oct 2018 07:06:45 -0700 (PDT) Return-Path: Received: from rpluim-ubuntu (cust-west-pareq2-46-193-13-178.wb.wifirst.net. [46.193.13.178]) by smtp.gmail.com with ESMTPSA id f7-v6sm26519095wrr.68.2018.10.11.07.06.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Oct 2018 07:06:43 -0700 (PDT) From: Robert Pluim To: martin rudalics Cc: Tjernlund , 32975@debbugs.gnu.org Subject: Re: bug#32975: Emacs 26.1; GTK Warnings References: <1538936366.8755.2.camel@tjernlund.se> <837eiryx33.fsf@gnu.org> <1539108072.8755.7.camel@tjernlund.se> <83zhvnx9ua.fsf@gnu.org> <1539110025.8755.10.camel@tjernlund.se> <83va6bx7a3.fsf@gnu.org> <87d0si1b41.fsf@gmail.com> <5BBDBC75.2010605@gmx.at> <875zya15cm.fsf@gmail.com> <1539193453.8755.14.camel@tjernlund.se> <871s8x0zgw.fsf@gmail.com> <87tvltylya.fsf@gmail.com> <5BBF08A6.3050604@gmx.at> <87pnwgzxuz.fsf@gmail.com> <5BBF10C4.4080008@gmx.at> <87lg74zvl5.fsf@gmail.com> <5BBF18C8.2040201@gmx.at> <87k1mo3j8z.fsf@gmail.com> <5BBF3BD1.4080204@gmx.at> <87efcw3c01.fsf@gmail.com> <5BBF555B.3020003@gmx.at> X-Debbugs-No-Ack: yes Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Thu, 11 Oct 2018 16:06:42 +0200 In-Reply-To: <5BBF555B.3020003@gmx.at> (martin rudalics's message of "Thu, 11 Oct 2018 15:51:23 +0200") Message-ID: <87a7nk37d9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Evolution-POP3-UID: UID7940-1100109815 X-Evolution-Source: 1390845712.25829.1@jocke Content-Transfer-Encoding: 8bit martin rudalics writes: >> How about moving the >> check for USE_TOOLKIT_SCROLL_BARS down into xg_set_background_color >> like so (which I think was your original suggestion): > > That's what I would do for Emacs 26.2. Sure. Eli, is the following OK for you? Itʼs a pretty rare setup, so master would probably be fine as well. Robert >From 21e193c8211d21cd46c2ee90902ae627e837a62f Mon Sep 17 00:00:00 2001 From: Robert Pluim Date: Thu, 11 Oct 2018 16:02:51 +0200 Subject: [PATCH] Call GTK functions only on GTK scrollbars To: emacs-devel@gnu.org * src/gtkutil.c (xg_set_background_color) [USE_TOOLKIT_SCROLL_BARS]: Don't call GTK functions on non-GTK scrollbars (Bug#32975). --- src/gtkutil.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gtkutil.c b/src/gtkutil.c index 6b72671da9..5879ab683e 100644 --- a/src/gtkutil.c +++ b/src/gtkutil.c @@ -1498,6 +1498,7 @@ xg_set_background_color (struct frame *f, unsigned long bg) block_input (); xg_set_widget_bg (f, FRAME_GTK_WIDGET (f), FRAME_BACKGROUND_PIXEL (f)); +#ifdef USE_TOOLKIT_SCROLL_BARS Lisp_Object bar; for (bar = FRAME_SCROLL_BARS (f); !NILP (bar); @@ -1508,7 +1509,7 @@ xg_set_background_color (struct frame *f, unsigned long bg) GtkWidget *webox = gtk_widget_get_parent (scrollbar); xg_set_widget_bg (f, webox, FRAME_BACKGROUND_PIXEL (f)); } - +#endif unblock_input (); } } -- 2.19.0.271.gfe8321ec05