[patch] Change the pkg_nofetch example and add a note

0001-ebuild-writing-functions-pkg_nofetch-Do-not-referenc.patch (text/plain), 1.30 KB, created by Ulrich Müller on 2017-03-17 10:00:29 UTC

From 19f871d4cee541c7e11fd23e9df591b940cb87ca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <[e-mail]>
Date: Fri, 17 Mar 2017 10:41:55 +0100
Subject: [PATCH] ebuild-writing/functions/pkg_nofetch: Do not reference
 DISTDIR.

According to PMS, the DISTDIR variable is not valid in pkg_* phases.
In addition, it is not guaranteed to be consistent across the ebuild
environment. So the package manager is allowed to (and Portage does)
redefine it to point to a temporary "shadow" instead of the global
distfiles directory.
---
 ebuild-writing/functions/pkg_nofetch/text.xml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/ebuild-writing/functions/pkg_nofetch/text.xml b/ebuild-writing/functions/pkg_nofetch/text.xml
index f360607..a03d552 100644
--- a/ebuild-writing/functions/pkg_nofetch/text.xml
+++ b/ebuild-writing/functions/pkg_nofetch/text.xml
@@ -54,9 +54,13 @@ pkg_nofetch() {
     einfo "Please download"
     einfo "  - ${P}-main.tar.bz2"
     einfo "  - ${P}-extras.tar.bz2"
-    einfo "from ${HOMEPAGE} and place them in ${DISTDIR}"
+    einfo "from ${HOMEPAGE} and place them in your DISTDIR directory."
 }
 </codesample>
+<note>
+The <c>DISTDIR</c> variable is not valid in <c>pkg_*</c> phases, so it must not
+be referenced.
+</note>
 </body>
 </section>
 
-- 
1.9.3