[patch] Add code to display script name for cron.{h,d,w,m}*

cronbase-scriptnames.patch (text/plain), 1.43 KB, created by Tobias Klausmann (RETIRED) on 2015-02-16 12:34:39 UTC

Author: Tobias Klausmann <[e-mail]>
Date:   Mon Feb 16 13:32:04 2015 +0100

    Add code to display script name for cron.{h,d,w,m}*
    
    If there are a lot of scripts in the hourly/daily/weekly/monthly cron
    directories, it can become very difficult to hunt down which script a
    particular message comes from. This patch prefixes script output with
    the name and exit status of the script that was run.
    
    This also changes behavior fro scripts that exit with non-zero status
    but no output. Previously, there would be no message indicating the
    (possible) failure. To recreate that behaviour (and only send messages
    on output being non-empty), those scripts can be amended with an
    unconditional "exit 0" or similar.

diff --git a/files/run-crons-0.3.3 b/files/run-crons-0.3.3
index 8b0116c..107717a 100755
--- a/files/run-crons-0.3.3
+++ b/files/run-crons-0.3.3
@@ -99,7 +99,14 @@ for BASE in hourly daily weekly monthly ; do
 		for SCRIPT in $CRONDIR/* ; do
 			if [[ -x $SCRIPT && ! -d $SCRIPT ]]; then
 				[ -x /usr/bin/logger ] && /usr/bin/logger -i -p cron.info -t run-crons "(`whoami`) CMD ($SCRIPT)"
-				$SCRIPT
+				TMPFILE=$(tempfile --prefix run-crons --suffix .log)
+				$SCRIPT &> "$TMPFILE"
+				RETVAL=$?
+				if [[ $(stat -c %b $TMPFILE) -gt 0 || $RETVAL -ne 0 ]]; then
+					echo "run-crons: $SCRIPT exited with $RETVAL, output:"
+					cat "$TMPFILE"
+				fi
+				rm -f "$TMPFILE"
 			fi
 		done
 	fi