[patch] Add repoman check for trailing punctuation

0001-Have-repoman-warn-when-DESCRIPTION-ends-with-a-punct.patch (text/plain), 1.72 KB, created by Michael Orlitzky on 2014-04-18 23:06:16 UTC

From b60ea34beaf1846956216a05f65f43607f028afa Mon Sep 17 00:00:00 2001
From: Michael Orlitzky <[e-mail]>
Date: Fri, 18 Apr 2014 18:44:17 -0400
Subject: [PATCH 1/1] Have repoman warn when $DESCRIPTION ends with a
 punctuation character.

---
 bin/repoman | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/bin/repoman b/bin/repoman
index 888892b..e035aee 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -318,6 +318,7 @@ qahelp = {
 	"LICENSE.missing": "Ebuilds that have a missing or empty LICENSE variable",
 	"LICENSE.virtual": "Virtuals that have a non-empty LICENSE variable",
 	"DESCRIPTION.missing": "Ebuilds that have a missing or empty DESCRIPTION variable",
+    "DESCRIPTION.punctuation": "DESCRIPTION ends with a punctuation character",
 	"DESCRIPTION.toolong": "DESCRIPTION is over %d characters" % max_desc_len,
 	"EAPI.definition": "EAPI definition does not conform to PMS section 7.3.1 (first non-comment, non-blank line)",
 	"EAPI.deprecated": "Ebuilds that use features that are deprecated in the current EAPI",
@@ -385,6 +386,7 @@ qawarnings = set((
 "dependency.badindev",
 "dependency.badmaskedindev",
 "dependency.badtilde",
+"DESCRIPTION.punctuation",
 "DESCRIPTION.toolong",
 "EAPI.deprecated",
 "HOMEPAGE.virtual",
@@ -1890,6 +1892,12 @@ for x in effective_scanlist:
 					stats[myqakey] += 1
 					fails[myqakey].append(relative_path)
 
+		if myaux['DESCRIPTION'][-1] in ['.', '?', '!']:
+			stats['DESCRIPTION.punctuation'] += 1
+			fails['DESCRIPTION.punctuation'].append(
+				"%s: DESCRIPTION ends with punctuation character '%s'" % \
+				(relative_path, myaux['DESCRIPTION'][-1]))
+
 		# 14 is the length of DESCRIPTION=""
 		if len(myaux['DESCRIPTION']) > max_desc_len:
 			stats['DESCRIPTION.toolong'] += 1
-- 
1.8.3.2