prevent gnome-clocks from creating broken clocks. applied upstream.

gnome-clocks-3.8.1-null-timezone.patch (text/plain), 1.59 KB, created by Evgeny Bobkin on 2013-05-06 20:00:11 UTC

From 3b94a3d5afa0385a63404e91d11b40dd50c46a8c Mon Sep 17 00:00:00 2001
From: Evgeny Bobkin <[e-mail]>
Date: Mon, 6 May 2013 12:10:43 +0200
Subject: [PATCH] prevent creating clocks for locations with no timezone.
 
Here, by creating a new clock for a defined and matched location the OK button
of the dialog remains disabled, if the time zone for this location is not
known, so the user cannot add such a broken clock. In this case a
warning message is produced.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=699311
---
 src/world.vala | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
 
diff --git a/src/world.vala b/src/world.vala
index dcc1385..01bcfd1 100644
--- a/src/world.vala
+++ b/src/world.vala
@@ -204,14 +204,22 @@ private class LocationDialog : Gtk.Dialog {
 
     private void location_changed () {
         GWeather.Location? l = null;
+        GWeather.Timezone? t = null;
         if (entry.get_text () == "") {
             entry.set_icon_from_gicon (Gtk.EntryIconPosition.SECONDARY, find_icon);
         } else {
             entry.set_icon_from_gicon (Gtk.EntryIconPosition.SECONDARY, clear_icon);
             l = entry.get_location ();
+            if (l != null) {
+                t = l.get_timezone ();
+
+                if (t == null) {
+                    GLib.warning ("Timezone not defined for %s. This is a bug in libgweather database", l.get_city_name ());
+                }
+            }
         }
 
-        set_response_sensitive(1, l != null);
+        set_response_sensitive(1, l != null && t != null);
     }
 
     public Item? get_location () {
-- 
1.8.1.5